Skip to content

Move between days inside the home page's day dialog - #153

Open
wayx112 wants to merge 1 commit into
Team6083:mainfrom
wayx112:feat/day-dialog-nav
Open

wayx112 wants to merge 1 commit into
Team6083:mainfrom
wayx112:feat/day-dialog-nav

Conversation

@wayx112

@wayx112 wayx112 commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Summary

The availability dialog on the home page shows one day. To see another, you had to close it, use the arrows on the section behind it, and open it again. This puts the same day picker in the dialog.

dialog header      < 11/15 Sun >                       Today
                   (on today: < 11/16 Mon > [Today badge], the Today button hidden in place)
section behind     its own arrows hidden while the dialog is open (space kept, no layout jump)
  • Header: arrows around the date, and Today on the right, clear of the close button. The section and the dialog share the selected day (DayAttendanceProvider), so closing the dialog leaves the section on the day you moved to.
  • Stays open while moving: the dialog content is no longer remounted per day. Remounting removed the button that had just been clicked, and the dialog closed. The day change now resets the view to the list in place. For the same reason, the Today button is kept on today and only hidden.
  • Loading: the dialog now renders before the next day has loaded, with a spinner, and a retry if it fails. The list stays mounted, hidden, so the search box keeps its text and doesn't take focus again on desktop after each move.
  • Scope: only the home page's day dialog gets the picker (dayNav on UserListDialog); the week page's dialogs are unchanged.

Evidence

On a local preview:

open the dialog on today        < 11/16 Mon > Today badge; section arrows hidden
previous day                    11/15 Sun, dialog stays open, Today button on the right, focus stays on the arrow
Today                           back to 11/16, dialog stays open
phone width (375 px)            header fits with the close button; no horizontal scroll
Test Files  25 passed (25)
     Tests  333 passed (333)

tsc --noEmit, ESLint on the changed files and npm run build pass.

Merge danger

Door: two-way. Display only; 2 files.

Blast radius: the home page's availability section and its dialog.

🤖 Generated with Claude Code

The availability dialog on the home page showed one day; to see another you had to close it, use the arrows
behind it and open it again. Its header now has the same arrows around the date, with Today on the right, and the
section's own arrows are hidden while it is open. Moving between days keeps the dialog open: the content isn't
remounted, the Today button stays in place (hidden on today), and the list stays mounted while the next day loads,
so the search box doesn't take focus each time.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant