chore(node): session timeout put to trace#638
Open
0xThemis wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Logging-only change; timeout metrics and WebSocket close behavior are unchanged.
Overview
When an OPRF WebSocket session exceeds
max_connection_lifetime, the log for that timeout is downgraded fromwarnwithuser_error=truetotrace, with the same message text. Timeout handling is unchanged:inc_client_timeout()still runs and the connection still closes with the TIMEOUT close frame.Reviewed by Cursor Bugbot for commit ac83380. Bugbot is set up for automated code reviews on this repo. Configure here.