Allow insertion, deletion & query to Traitor Radio sound table#1876
Open
Guy-L wants to merge 1 commit into
Open
Allow insertion, deletion & query to Traitor Radio sound table#1876Guy-L wants to merge 1 commit into
Guy-L wants to merge 1 commit into
Conversation
Author
|
Seems there was a base TTT update to address this specific issue that hasn't been added to TTT2 yet: #1841 Leaving this up in case this is PR is an acceptable implementation |
Member
|
Hey, thanks for your work on this! Though, we would prefer an implementation with the same API as the original TTT code here, so we can stay compatible with TTT addons. It seems that in Facepunch/garrysmod#2354, they added So if you want to go forward with this and get this in, i'd recommend you implement the same changes from the base TTT PR in TTT2 :) Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there's no clean way for addons to add new sounds to the Radio weapon's sound list. This limits opportunities for addons that have unique sound cues that may be worth faking as Traitor. This PR adds a few API methods to interact with the radio sound list, which addons can use at initialization time.