Pass width and height to copyStagingToAccumulation#20
Conversation
- Updated `copyStagingToAccumulation` in `src/VulkanRayTracing.cpp` to use `width` and `height` parameters instead of hardcoded 1920x1080 resolution. - Verified that call sites in `src/main.cpp` pass the correct resolution constants. - Confirmed that `copyAccumulationToStaging` also uses dynamic resolution.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This change fixes the hardcoded resolution issue in
copyStagingToAccumulation. The function now correctly uses the passedwidthandheightarguments to define the image copy region. This ensures the function works correctly for any resolution, matching the behavior ofcopyAccumulationToStaging.PR created automatically by Jules for task 486220528594492004 started by @TECHNICANGEL