⚡ Avoid redundant vector allocation in EntityManager#14
Conversation
- Added `mutable std::vector<Transform> cachedTransforms` to EntityManager. - Updated `getTransforms` to return `const std::vector<Transform>&`. - Reused `cachedTransforms` to avoid per-frame allocation. - Updated `main.cpp` to use the returned reference.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What
Optimized
EntityManager::getTransformsto avoid allocating a newstd::vector<Transform>every frame.🎯 Why
Allocating memory in the main render loop is expensive and causes heap fragmentation. By reusing a persistent vector as a cache, we reduce allocator overhead.
📊 Measured Improvement
Benchmark Results:
Note: The benchmark environment showed high variance, masking the micro-optimization gains. However, this is a standard zero-allocation pattern for high-performance loops. Theoretically, it removes
malloc/freecycles for thetransformsvector every frame.PR created automatically by Jules for task 369316685402116316 started by @TECHNICANGEL