Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces, for the most part, a "cleaned-up" version of the issue classifier component, i.e. unused imports have been removed for clarity as well as performance, variable names have been renamed to better reflect their purpose/nature of content.
This, however, does not mean that the code is in a perfectly usable state. In particular, further rewriting of code (for example due to modifications to architecture) may be necessary to produce a production-ready release suitable for a given context.
In addition, the web server has been rewritten to utilise Flask as a Web framework, with an MQTT client to communicate with the standing between the Microservice and the Gropius tool. Intra-microservice communication will (probably) be carried out using AMQP as well as Celery, publish all issues to different pre-trained classifiers, where a single issue will be sent to a task queue, with several instances of the same pre-trained classifier competing for the issue to be classified (competing consumers pattern).
Furthermore, the entire architecture should be Dockerised and made easily integrable with Kubernetes for scenarios where scalability is of high importance.
A further study of the pros and cons of AMQP in comparison to MQTT w.r.t. a pubsub pattern is still required, though I assume that any benefits/drawbacks introduced by the one or the other are of negligible consequence to the overall target efficiency and/or operability of the Microservice.