Update naga_oil to use update-deps branch and bump wgpu to v27#91
Update naga_oil to use update-deps branch and bump wgpu to v27#91sytherax wants to merge 2 commits into
Conversation
…mpatibility issues Amp-Thread-ID: https://ampcode.com/threads/T-63ae05f0-8d29-42c5-9ad7-ca1bb3e894d8 Co-authored-by: Amp <amp@ampcode.com>
Please double check the following review of the pull request:
Changes in the diff
Identified Issues
Issue 1ExplanationIn Suggested fixAdjust the indentation of the quoted code block to align properly with the surrounding code: naga::ImageClass::Storage { format, access } => {
// TODO: Will the debug implementation always work with the macro?
// Assume texture format variants are the same as storage formats.
let format = syn::Ident::new(&format!("{format:?}"), Span::call_site());
let storage_access = storage_access(*access);
quote!(wgpu::BindingType::StorageTexture {
access: #storage_access,
format: wgpu::TextureFormat::#format,
view_dimension: #view_dim,
})
}Explanation of fixProper indentation improves code readability and maintainability, making it easier for developers to understand the structure and flow. Missing testsNo new functionality or behavior changes that require additional tests were introduced in this diff. The changes are mostly dependency bumps, minor API usage updates, and code generation adjustments. Existing tests should cover the updated code paths. Summon me to re-review when updated! Yours, Gooroo.dev |
|
naga_oil latest now supports wgpu 27 |
Removed patch for naga_oil dependency in Cargo.toml
|
Resolved in #97 |
This PR updates the naga_oil dependency to use the `update-deps` branch from https://github.com/sytherax/naga_oil, which brings in naga v27. To maintain compatibility, wgpu and wgpu-types have been updated to v27 as well. Fixed breaking changes including adding support for ImageClass::External and updating PollType::Wait API usage.
All tests pass.