Update dependencies and fix API changes#89
Merged
Merged
Conversation
- Update encase to 0.12.0 - Update naga to 26.0.0 (compatible with naga_oil) - Update naga_oil to 0.19.1 - Update toml to 0.9.8 - Update wgpu to 26.0.1 - Update wgpu-types to 26.0.0 - Fix wgpu API changes: poll() and RenderPassColorAttachment - Fix clippy warnings: use is_multiple_of() instead of % == 0 - Run cargo fmt on all files Amp-Thread-ID: https://ampcode.com/threads/T-53d0efdc-a9c2-49ad-939b-14683365a903 Co-authored-by: Amp <amp@ampcode.com>
Please double check the following review of the pull request:
Changes in the diff
Identified Issues
Issue 1ExplanationIn let _ = device.poll(wgpu::PollType::Wait).unwrap();This unwraps the Result returned by Suggested fixHandle the error explicitly instead of unwrapping: if let Err(e) = device.poll(wgpu::PollType::Wait) {
eprintln!("Warning: device.poll() failed: {:?}", e);
}Explanation of the fixThis avoids panicking on poll errors and logs the error instead, improving robustness. Missing testsNo new features or logic changes were introduced that require new tests. The changes are mostly dependency updates and API adjustments. Existing tests should suffice. Summon me to re-review when updated! Yours, Gooroo.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amp-Thread-ID: https://ampcode.com/threads/T-53d0efdc-a9c2-49ad-939b-14683365a903