(fix) Add missing English translation keys - #612
theluckystrike wants to merge 1 commit into
Conversation
Four translation keys used in the dashboard are not defined in en.json or any other locale, so i18next renders the raw key: - alert.noCustomEventError: alert form validation for custom events - common.select: targeting rule column picker in feature flag settings - titles.unsubscribe: Open Graph image title on the reports unsubscribe page - apiNotifications.errorOccured: organisation creation error; switch to the existing common.errorOccured key instead of adding a duplicate Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configuration
π Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. π WalkthroughWalkthroughThe change updates the translation key used for new-organisation errors and adds three English locale entries for a common label, alert validation, and the email reports unsubscribe page. ChangesUI translation updates
Priority: β¬οΈ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Suggested reviewers: Merge Risk: βͺ Minimal Β· up to The English messages match their identified UI consumers, and organisation errors retain their interpolation. No actionable merge-blocking risk is evident. π₯ Pre-merge checks | β 5β Passed checks (5 passed)
β¨ Finishing Touchesπ§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Changes
Four keys used in the dashboard are not in
en.jsonor any other locale file, so i18next falls back to the raw key and users see text likealert.noCustomEventError:alert.noCustomEventError: validation message when a custom event alert has no event name (ProjectAlertsSettings.tsx:331)common.select: placeholder of the column picker in feature flag targeting rules (FeatureFlagSettingsModal.tsx:509)titles.unsubscribe: Open Graph image title on the reports unsubscribe page (reports-unsubscribe.$token.tsx:20). The text matches the page title already set there.apiNotifications.errorOccuredinOrganisations.tsx:314: the key does not exist, butcommon.errorOccuredhas the same text and placeholder, so the call now uses that instead of adding a duplicate.Only
en.jsonis edited. The other locales come from Crowdin and will pick the new keys up on the next sync.Separate from this PR: in the Crowdin output,
project.metrics.filterKVinde.jsondrops{{metricKey}}and inuk.jsonswaps{{metricKey}}and{{customEventName}}. I left those for Crowdin rather than editing the generated files.Testing
Checked on
mainthat none of the four keys exist in any locale file. Inweb:npm run lint,npm run format:check,npm run typecheckandnpm run knipall pass.AI assistance
Prepared with AI assistance and reviewed line by line. Claude Opus 5.5 in Claude Code found the missing keys and drafted the change.
Checklist
Summary by CodeRabbit
Bug Fixes
Translations