Skip to content

(fix) Add missing English translation keys - #612

Open
theluckystrike wants to merge 1 commit into
Swetrix:mainfrom
theluckystrike:fix/swetrix-missing-en-keys
Open

theluckystrike wants to merge 1 commit into
Swetrix:mainfrom
theluckystrike:fix/swetrix-missing-en-keys

Conversation

@theluckystrike

@theluckystrike theluckystrike commented Oct 4, 2026 •

Copy link
Copy Markdown

Changes

Four keys used in the dashboard are not in en.json or any other locale file, so i18next falls back to the raw key and users see text like alert.noCustomEventError:

  • alert.noCustomEventError: validation message when a custom event alert has no event name (ProjectAlertsSettings.tsx:331)
  • common.select: placeholder of the column picker in feature flag targeting rules (FeatureFlagSettingsModal.tsx:509)
  • titles.unsubscribe: Open Graph image title on the reports unsubscribe page (reports-unsubscribe.$token.tsx:20). The text matches the page title already set there.
  • apiNotifications.errorOccured in Organisations.tsx:314: the key does not exist, but common.errorOccured has the same text and placeholder, so the call now uses that instead of adding a duplicate.

Only en.json is edited. The other locales come from Crowdin and will pick the new keys up on the next sync.

Separate from this PR: in the Crowdin output, project.metrics.filterKV in de.json drops {{metricKey}} and in uk.json swaps {{metricKey}} and {{customEventName}}. I left those for Crowdin rather than editing the generated files.

Testing

Checked on main that none of the four keys exist in any locale file. In web: npm run lint, npm run format:check, npm run typecheck and npm run knip all pass.

AI assistance

Prepared with AI assistance and reviewed line by line. Claude Opus 5.5 in Claude Code found the missing keys and drafted the change.

Checklist

  • Database: no migrations needed.
  • Edition coverage: the strings live in the web app both editions use; no edition-specific code changed.
  • Documentation: no changes needed, these are UI strings only.

Summary by CodeRabbit

  • Bug Fixes

    • Updated the error message shown when creating an organisation.
  • Translations

    • Added English text for a selection label, custom event name validation, and the email report unsubscribe page title.

Four translation keys used in the dashboard are not defined in en.json
or any other locale, so i18next renders the raw key:

- alert.noCustomEventError: alert form validation for custom events
- common.select: targeting rule column picker in feature flag settings
- titles.unsubscribe: Open Graph image title on the reports unsubscribe page
- apiNotifications.errorOccured: organisation creation error; switch to
  the existing common.errorOccured key instead of adding a duplicate

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Review in Change Stack β†’

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. πŸŽ‰

ℹ️ Recent review info
βš™οΈ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 76ef101e-1628-484c-9cc6-71d46b5f799b
πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between dc99b80 and 80d08ca.

πŸ“’ Files selected for processing (2)
  • web/app/pages/Organisations/Organisations.tsx
  • web/public/locales/en.json

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.


πŸ“ Walkthrough

Walkthrough

The change updates the translation key used for new-organisation errors and adds three English locale entries for a common label, alert validation, and the email reports unsubscribe page.

Changes

UI translation updates

Layer / File(s) Summary
Add English locale entries
web/public/locales/en.json
The English locale adds the β€œSelect” label, a message asking users to enter a custom event name, and the unsubscribe email reports page title.
Update organisation error translation key
web/app/pages/Organisations/Organisations.tsx
The new-organisation error display now uses common.errorOccured instead of apiNotifications.errorOccured.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: blaumaus

Merge Risk: βšͺ Minimal Β· up to 80d08

The English messages match their identified UI consumers, and organisation errors retain their interpolation. No actionable merge-blocking risk is evident.

πŸš₯ Pre-merge checks | βœ… 5
βœ… Passed checks (5 passed)
Check name Status Explanation
Title check βœ… Passed The title clearly identifies the main change: adding missing English translation keys. It is concise and specific.
Description check βœ… Passed The description covers the changes, testing, AI assistance, and all checklist items required by the template. It explains why other locales and documentation were not changed.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check βœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check βœ… Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
πŸ§ͺ Generate unit tests (beta)
  • Create a new PR
  • Autopilot Β· Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant