Add per-player joystick configuration system#3816
Open
catzh23 wants to merge 1 commit into
Open
Conversation
Replace single global joystick config with per-player independent configurations. Each player now has their own JoystickConfig instance stored in a map<int, JoystickConfig> keyed by player ID. Bindings are stored as (player, button) pairs, consistent with KeyboardConfig's PlayerControl approach. The JoystickMenu mirrors KeyboardMenu, showing Player 2, 3 entries for additional players. Configurations are serialised to the existing config.cfg under a new joystick-configs section, with migration support for the old single-config format. Closes SuperTux#3572 Co-authored-by: Joana Saraiva <joana.t.saraiva@tecnico.ulisboa.pt>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace single global joystick config with per-player independent configurations.
Each player now has their own JoystickConfig instance stored in a map<int, JoystickConfig> keyed by player ID. Bindings are stored as (player, button) pairs, consistent with KeyboardConfig's PlayerControl approach. The JoystickMenu mirrors KeyboardMenu, showing Player 2, 3 entries for additional players. Configurations are serialised to the existing config.cfg under a new joystick-configs section, with migration support for the old single-config format.
The JoystickMenu changes also update refresh_menu_item to refresh_control, mirroring the pattern used in KeyboardMenu, which we considered pertinent as part of modernising the menu.
Closes #3572