Skip to content

Achievements implementation: Part 1#3797

Draft
MatusGuy wants to merge 7 commits into
masterfrom
cheevos
Draft

Achievements implementation: Part 1#3797
MatusGuy wants to merge 7 commits into
masterfrom
cheevos

Conversation

@MatusGuy

@MatusGuy MatusGuy commented May 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

For now, this pull request is intended to take care of

  • the architecture for the cheevos manager
  • the local cheevos service provider
  • the UI for notifying unlocked cheevos and viewing cheevo progress

I would also like to take care of

  • the cheevo design itself. What is the list of cheevos and their rarities?
  • the cheevo icons (aka badges).

MatusGuy added 5 commits May 2, 2026 17:09
@MatusGuy
wip stub
3f7dbb3 
Defined basic architecture and etc.

It doesn't work right now because PHYSFS_close crashes the game for some
reason.
@MatusGuy
ditch ofilestream
305b967
@MatusGuy
Add debug cheevos menu, unlock notif, and fix saving/loading
54d4c60
@MatusGuy
cheevo image wip
7cfed1b
@MatusGuy
fix cheevo loading
510e56d
@MatusGuy MatusGuy marked this pull request as draft May 9, 2026 13:09
@MatusGuy MatusGuy self-assigned this May 9, 2026
@MatusGuy MatusGuy added status:needs-discussion Team member and developers need to discuss of decisions category:code category:design labels May 9, 2026
@MatusGuy MatusGuy linked an issue May 9, 2026 that may be closed by this pull request
Achievement management implementation proposal #3792
Open
tobbi
tobbi reviewed May 9, 2026
View reviewed changes
Comment thread src/cheevos/cheevo_manager.cpp
}

std::vector<bool> const&
CheevoManager::get_unlocked(const Profile& profile, const Addon* addon)

@tobbi tobbi May 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be const?

@MatusGuy MatusGuy May 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excuse me?

@MatusGuy MatusGuy May 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Maybe.

tobbi
tobbi reviewed May 9, 2026
View reviewed changes
Comment thread src/cheevos/cheevo_manager_local.cpp

std::vector<bool> const&
CheevoManager::get_unlocked_local(const Profile& profile, const Addon* addon)
{

@tobbi tobbi May 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for this re const correctness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobbi tobbi tobbi left review comments

Assignees

@MatusGuy MatusGuy

Labels

category:code category:design status:needs-discussion Team member and developers need to discuss of decisions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Achievement management implementation proposal

2 participants

@MatusGuy @tobbi