Skip to content

Add back the 1D OKLab color picker#3764

Open
HybridDog wants to merge 1 commit into
SuperTux:masterfrom
HybridDog:m_colour_chooser_1d_is_back
Open

Add back the 1D OKLab color picker#3764
HybridDog wants to merge 1 commit into
SuperTux:masterfrom
HybridDog:m_colour_chooser_1d_is_back

Conversation

@HybridDog

Copy link
Copy Markdown
Contributor

There are complaints that with the 2D colour picker only fully-saturated colours can be selected and requests to add back a saturation slider.

This reverts commit d7e6703, i.e. it adds back the 1D sliders next to the 2D picker.

There are complaints that with the 2D colour picker only fully-saturated
colours can be selected and requests to add back a saturation slider.

This reverts commit d7e6703, i.e. it
adds back the 1D sliders next to the 2D picker.
@HybridDog

HybridDog commented Mar 27, 2026

Copy link
Copy Markdown
Contributor Author

Related discussions:

@MatusGuy MatusGuy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Knowing that this is a revertion of an existing commit, it LGTM (code, test).

However, and I know this is not quite what is being referenced here, soon I think there should be a way to use an actual RGB 2D color picker. I think an OKLab color picker makes more sense as 1d sliders than as a 2d square. This is because with a 2d oklab color picker, some colors are easier to pick than others, as opposed to a normal RGB version.

@Eauix

Eauix commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

I hadn't had the time to test it properly yet, but I noticed that the saturation slider gets altered automatically in some unpredictable ways when you change the color's brightness, which is kinda annoying

The thing is, I don't remember if this situation happened before the 2d color picker was implemented, I'll try to test an old version to tell this

Also, it'd be nice if the 2d picker could change its saturation to represent the true color it'll select when you move the saturation slider

But tbh, I wouldn't mind if the 2d picker was just removed

@MatusGuy

Copy link
Copy Markdown
Contributor

I hadn't had the time to test it properly yet, but I noticed that the saturation slider gets altered automatically in some unpredictable ways when you change the color's brightness, which is kinda annoying

I believe this is a byproduct of OKLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants