Fix #3569: Fix Tux not turning around in 1-block gaps#3745
Open
gvalves2005 wants to merge 1 commit into
Open
Conversation
tobbi
reviewed
Mar 18, 2026
gvalves2005
force-pushed
the
fix-bug-3569
branch
from
c001c02 to
e568e5a
Compare
When Tux is in a 1-block gap, his horizontal velocity becomes zero. If the fancy idle timer was active, the draw() function would wait for the timer to finish before updating the sprite's direction, ignoring user input. This patch adds a check during the idle wait state to force an action update if the direction changes, resetting the idle stage to zero. A unit test (PlayerAnimationTest) was also added to verify the state machine logic for the idle animation turnaround Closes SuperTux#3569
gvalves2005
force-pushed
the
fix-bug-3569
branch
from
e568e5a to
efb197c
Compare
Author
|
Just noticed I missed an 'S' on IDLE_STAGES which upset the CI. Force-pushed the compilation fix! |
Author
|
Hi @tobbi! Hope you're doing well. I just wanted to check in on the status of this PR. Let me know if the current implementation looks good to you, or if I need to adjust anything else. |
Member
|
Thank you! From my side it looks good. I'm checking in with the rest of the team. One thing I'm not sure about: There's some code duplication and I'm wondering whether that can be moved into its own function. But I'll discuss that with the rest of the team first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #3569, where Tux ignores user directional input when placed in a 1-block gap while the fancy idle animation timer is active.
Root Cause & Fix
When Tux's horizontal velocity becomes zero, the
draw()function inplayer.cppwaits for the idle timer to finish before updating the sprite's direction. This patch adds a check during the idle wait state to force an action update if the direction changes, resetting the idle stage to zero.Testing
I validated this fix via manual runtime testing.
Closes #3569