feat: allow to pass pug locals with <pug> tag using custom attribute#14
Open
felixranesberger wants to merge 1 commit into
Open
feat: allow to pass pug locals with <pug> tag using custom attribute#14felixranesberger wants to merge 1 commit into
felixranesberger wants to merge 1 commit into
Conversation
Contributor
Author
|
Hi, any feedback on this pull request? :) |
Owner
|
I think this feature is a good idea as it would make templates more reusable, even if the proposed syntax isn't exactly eye candy. However, the change doesn't pass the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have the problem that I need to pass a file specific modifier class to the tag. This pull reqest allows to pass pug locals to individual pug tags via encodeURIComponent strings.
I would appreciate feedback on the implementation, as I'm not sure if there is a better way.
HTML Code
Pug File: