[Feature] Tray menu server status#44
Open
elpiel wants to merge 27 commits into
Open
Conversation
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
Open
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
elpiel
force-pushed
the
feat/tray-menu-server-status
branch
from
889e543 to
dd19a26
Compare
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
elpiel
force-pushed
the
feat/tray-menu-server-status
branch
from
d60a15a to
aa8a1dc
Compare
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
elpiel
force-pushed
the
feat/tray-menu-server-status
branch
from
9d8c19c to
bd2d29b
Compare
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
tymmesyde
reviewed
Jan 12, 2024
| pub fn new(directory: PathBuf) -> Result<Self, Error> { | ||
| pub fn at_dir(directory: PathBuf, no_cors: bool) -> Result<Self, Error> { | ||
| if directory.is_dir() { | ||
| let node = directory.join(Self::node_bin(None)?); |
Member
There was a problem hiding this comment.
This implementation seems convoluted compared to the one already present
Member
Author
There was a problem hiding this comment.
This makes sure to list all the missing binaries instead only the first one.
If a user complains about the Service not being able to run, this would help us with Support.
Member
|
Install with RPM package is broken, returning missing binary error |
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
elpiel
force-pushed
the
feat/tray-menu-server-status
branch
from
f84f84b to
921c293
Compare
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
elpiel
force-pushed
the
feat/tray-menu-server-status
branch
from
2e698aa to
1d59059
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--no-corsto disable the server cors check (i.e. pass aNO_CORS=1env. variable). You can still use an env. variable to set the env. variable and be passed to the server process.TODOs:
How test:
cargo run --releasecargo runOpen the Tray icon menu.
Release
Development