docs and support for player and library events#241
Open
dexter21767-dev wants to merge 3 commits into
Open
Conversation
elpiel
reviewed
Oct 9, 2023
elpiel
reviewed
Oct 11, 2023
elpiel
reviewed
Oct 13, 2023
elpiel
left a comment
elpiel
left a comment
Member
There was a problem hiding this comment.
Let me know if I've missed something @dexter21767-dev
| To define a minimal addon, you only need an HTTP server/endpoint serving a `/manifest.json` file and responding to resource requests at `/{resource}/{type}/{id}.json`. | ||
|
|
||
| Currently used resources are: `catalog`, `meta`, `stream`, `subtitles`, `watchStatus`. | ||
| Currently used resources are: `catalog`, `meta`, `stream`, `subtitles`, `player`, `library`. |
Comment on lines
29
to
32
| - Play: `action=play¤tTime={milliseconds}&duration={milliseconds}` | ||
| - Start: `action=start¤tTime={milliseconds}&duration={milliseconds}` | ||
| - End: `action=end¤tTime={milliseconds}&duration={milliseconds}` | ||
| - Pause: `action=pause¤tTime={milliseconds}&duration={milliseconds}` |
Member
There was a problem hiding this comment.
- Play and Pause should be separated into the
playbackevents resource - As we've discussed in Slack,
durationandcurrentTimemight not be available and are not required for each of these actions and must be made optional. Only Play and Pause make sense with those arguments.
elpiel
reviewed
Aug 12, 2024
Comment on lines
+37
to
+38
| - Add to library: `action=libraryAdd` | ||
| - Remove from library: `action=libraryRemove` |
Member
There was a problem hiding this comment.
I suggest to rename these to add and remove respectively.
We are already under the library resource and a simple action name would be sufficient
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.