Repository navigation
test: pin that Graphik() replaces an existing display mode - #56
Merged
dmccoystephenson merged 1 commit intoOct 21, 2026
Merged
Conversation
The no-argument constructor calls set_mode unconditionally, so a display mode the consumer already set is resized to 900x600 rather than adopted. Pin that with a characterization test and document it in the constructor docstring and the README method list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (anchored on CI
Observation outside the diff: in the mutation run, the existing This comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
dmccoystephenson
deleted the
test/pin-no-arg-constructor-replaces-display
branch
October 21, 2026 12:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Graphik()constructor when a display mode is already set.set_mode((900, 600))is called unconditionally, so the existing display is replaced and the consumer's window is resized to 900x600 instead of being adopted. This was neither documented nor tested.graphik.pyis in the docstring.Stage B (unit-test expansion) cycle, with the matching documentation update. No tracking issue exists; the gap was found during triage.
Test plan
python3 -m py_compile src/main/python/preponderous/graphik/graphik.pypytest: 68 passed (67 before, plus the new test)pygame.display.get_surface(), the new test failed. The change was then reverted.Deferred issues
All four open issues (#34, #39, #40, #46) were skipped. Each needs a change to
.github/workflows/or the release process, or a maintainer decision, as recorded in the issue bodies. Those areas are excluded from autonomous change.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson