Repository navigation
Pin that drawText leaves the surface visible around the glyphs - #53
Merged
Merged
Conversation
Every other text test draws onto a black background, where rendering with an opaque black background looks identical, so nothing caught a drawText that painted a box behind its text. Draw onto green instead and require the untouched part of the text rectangle to stay green. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (performed inline; no independent reviewer is configured —
Judgment note: This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
dmccoystephenson
deleted the
test/pin-draw-text-transparent-background
branch
October 18, 2026 12:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_draw_text_leaves_the_surface_visible_around_the_glyphs, is added. It pins thatdrawTextpaints only the glyphs: the rest of the rendered text's rectangle keeps whatever was already on the surface.drawButtonlabel tests, whose ink filter excludes black) draws onto a black background, where rendering with an opaque black background looks identical.drawButtonrelies on the transparent background to show its label overcolorBox..(which inks only the bottom of its line) onto a green surface and requires the top row of the centered text rectangle to stay green.Test plan
python3 -m pytest -q→ 64 passed (63 before).python3 -m py_compile src/main/python/preponderous/graphik/graphik.pysucceeds.drawTexttemporarily changed tomyFont.render(text, True, color, (0, 0, 0)), only the new test fails (1 failed, 63 passed); with the change reverted, all 64 pass.Triage notes (skipped issues)
This cycle was a Stage B (unit-test expansion) cycle, because every open issue is gated:
.github/workflows/, which is excluded from autonomous change.preponderous.*namespace convention across sibling projects.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson