Repository navigation
Document the view command's output in the README - #81
Merged
Merged
Conversation
Every other command has an examples section; view had only its one-line entry in the command list. Add a View Examples section showing the command, its output for the create example's project, the score words, and the not-found message. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric:
Finding (fixed in the second commit):
Not changed: the example output omits the blank line that Spring Shell prints after the trailing This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
README.mdandCONTRIBUTING.md.create,list,update,deleteandexporteach have an examples section in the README, butviewhas only its one-line entry in the command list. Its output format, the score words, and the not-found message were undocumented.View Examplessection is added betweenList ExamplesandUpdate Examples, which follows the order of the command list. It shows the output for the project from the create examples (-i 4 -c 3 -e 5 -r 2 -f 3).ViewProjectCommand.executesets the line order and labels, uses%.2ffor the ICE and RICE scores, and returnsProject not found: <name>for an unknown name.ScoreDescriptionProvider.getDescriptionmaps 1-5 tovery low/low/medium/high/very high, and any other value to its number.ViewProjectCommandTest.shouldShowRawNumberForScoreOutsideOneToFivealso covers this.ScoreCalculatorgives ICE = 4×3×5 = 60.00 and RICE = (2×4×3)÷3 = 8.00.CONTRIBUTING.mdmatch.github/workflows/ci.ymlandbuild.yml.No tracking issue exists for this change. The gap was found during triage.
Deferred: #27 (controller endpoints) is still blocked for the reasons recorded on the issue. It needs a web dependency in
build.gradle, which is on the do-not-auto-merge list, and the endpoint, port and bind-address decisions are still open.Test plan
ViewProjectCommand,ScoreDescriptionProviderandScoreCalculatorCI Pipeline,Build and Test) is green. The change is docs-only, so the local Gradle anchor is UNVERIFIED-not-applicable.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson