Repository navigation
Use ScoreDescriptionProvider in the view command - #79
Merged
dmccoystephenson merged 2 commits intoOct 29, 2026
Merged
Conversation
view kept a private copy of the score-to-description mapping that ScoreDescriptionProvider already centralizes for the Markdown export. Inject the provider instead, and pin the view output's exact ICE and RICE values and the raw-number fallback for a score outside 1-5. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (scored against
Notes:
No blocking findings. This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
dmccoystephenson
deleted the
feat/view-uses-score-description-provider
branch
October 29, 2026 04:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ViewProjectCommandnow hasScoreDescriptionProviderinjected, and its private copy of the score-to-description mapping is deleted. Theviewoutput and the Markdown export now share one mapping. The unusedjava.util.Listimport is dropped from the rewritten file.ViewProjectCommandTestnow checks the exactICE Score: 60.00/RICE Score: 40.00lines. Before, it only checked that the labels appeared.defaultfallback: a score outside 1–5 is shown as its raw number (Impact: 7).This is a behavior-preserving refactor. The provider's switch is identical to the deleted one, so the
viewoutput does not change.Closes #78
Issue #27 (HTTP controller endpoints) was skipped again. It still lacks the endpoint, payload, and port/bind-address decisions listed in its 2026-10-19 comment, and it would need a new web dependency in
build.gradle, which is on the loop's do-not-auto-merge list.Test plan
./gradlew teston JDK 21: 173 tests run, 0 failures, 0 errors, 0 skipped (counted frombuild/test-results/test/*.xml);ViewProjectCommandTestran 3 tests.viewentry (README.md:66) still describes the command accurately; no doc change needed.Build and Test/CI Pipelinegreen on the PR head.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson