Repository navigation
feat(security): harden the HTTP transport against SSRF and unsafe redirects - #143
Merged
Ayinkx01 merged 1 commit intoOct 28, 2026
Merged
Conversation
Reject private/link-local address literals, filter resolved DNS addresses, allow only re-validated same-host redirects, and re-check the final response URL. Document the network security policy.
Ayinkx01
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21
Summary
docs/NETWORK_SECURITY.mdand update related security/architecture docs.Tests
cargo test --workspace --all-featurespassed.cargo clippy -p devkit-rpc --all-targets --all-features -- -D warningspassed.Security notes
Cross-host redirects now fail closed instead of being silently followed. Loopback endpoints remain usable for local RPC nodes.