Canonicalize request bodies before computing idempotency digests#1606
Merged
kryputh merged 1 commit intoJul 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Enforce canonical JSON serialization for idempotency digests (issue #1501) so semantically identical requests hash the same while genuinely different values still conflict.
Changes
src/server/api/idempotency-service.ts:hashIdempotencyKeynow canonicalizes the raw key via the existing JCScanonicalize()helper before hashing, so object-key ordering no longer changes the digest.tests/unit/api/idempotency-canonicalization.test.ts: key-order invariance, array-order significance, numeric-vs-string distinction, nested-structure sensitivity, actor binding, and determinism.Verification
npx vitest run tests/unit/api/idempotency-canonicalization.test.ts→ 6 passed.npx prettier@3.8.5 --checkclean on changed files.Fixes #1501