V1]individual] email tone rewriter#1284
Open
clintjeff2 wants to merge 2 commits into
Open
Conversation
Add isolated Email Tone Rewriter UI surface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
EmailToneRewriter,EmailToneRewriterEmpty,EmailToneRewriterLoading,EmailToneRewriterError, andEmailToneRewriterSuccessundertools/v1/individual/email-tone-rewriter/components.tools/v1/individual/email-tone-rewriter/styles.cssand a visual/accessibility doc intools/v1/individual/email-tone-rewriter/docs/visual-style.mdwithout modifying the shared design system.tools/v1/individual/email-tone-rewriter/index.tstoexport * from "./components".tools/v1/individual/email-tone-rewriter/tests/components.test.tsthat validate labeled regions, radio-group semantics, keyboard shortcuts, loading/error semantics, focusable success output, disabled action copy, and state routing.Testing
git diff --cached --checkwhich passed with no issues.tools/v1/individual/email-tone-rewriter/tests/components.test.ts) and verification steps to run them withvitest, but executingbunx vitestin this environment failed while resolving test runner dependencies due to a registry403error so tests could not be completed here.tools/v1/individual/email-tone-rewriter/and component tests are included for CI to run in a network-enabled environment.Closes #351