V1]individual] grammar cleaner#1282
Open
clintjeff2 wants to merge 2 commits into
Open
Conversation
…r-cleaner Improve grammar cleaner homophone handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
there,their,your) dropped the following verb or descriptor during replacement and add a few common misspelling corrections.Description
your→you'rewith captured continuation,theirs→there's, andaccidently→accidentallyinsidetools/v1/individual/grammar-cleaner/services/grammarCleaner.ts.there ...andtheir ...rules by changing the replacements to include the capture ("they're $1"and similar) so verbs/descriptors are not dropped.tools/v1/individual/grammar-cleaner/tests/grammarCleaner.test.tsto assert phrase-preserving corrections and verify the new rules produce expected corrected text.Testing
git diff --checkto ensure no whitespace/patch issues and validated the diff of modified files undertools/v1/individual/grammar-cleaner/.bunx vitest run --config tools/v1/individual/grammar-cleaner/vitest.config.tsbut execution was blocked because the environment has no localnode_modulesand resolvingvitestfrom the npm registry returned HTTP 403, so tests could not complete in this environment.Closes #365