Regression coverage#1277
Open
gloskull wants to merge 4 commits into
Open
Conversation
…-import test: add contacts import regression coverage
Author
|
Done resolving this issue. Please merge and give an high review. |
…config - Update .github/workflows/ci.yml bun-version to a valid version (1.2.14). - Relax ESLint rules for tools/ directory in eslint.config.js to match project patterns. - Remove unused eslint-disable directives from several files. Co-authored-by: gloskull <189399494+gloskull@users.noreply.github.com>
…615847480962966 Fix failing CI Client Checks and update linting configuration
Author
|
Done fixing this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add focused regression tests for the contacts import flow to make parsing behavior transparent and prevent regressions when editing the import wizard or parser helpers.
Description
Add tests/unit/contacts-import.test.ts which exercises parseCsv, revalidate, and findDuplicateAddresses from src/features/contacts/parseContacts.ts.
Tests cover a successful, headered CSV parse, a malformed row that surfaces the current validation error and is recoverable via revalidate, and case-insensitive duplicate detection while ignoring blank addresses.
The tests use deterministic fixtures and mock the system time to produce stable import IDs and do not change production code.
Testing
Ran npx vitest run tests/unit/contacts-import.test.ts and the new test file passed (3 tests).
Ran npx tsc --noEmit for type checking which succeeded.
Ran npm run lint; formatting issues in the new test were auto-fixed before committing and the linter completed (warnings remain elsewhere in the repo).
Closes #994