(Run Select) update next page text if optional pages change#1437
Open
MetaNite64 wants to merge 1 commit into
Open
(Run Select) update next page text if optional pages change#1437MetaNite64 wants to merge 1 commit into
MetaNite64 wants to merge 1 commit into
Conversation
in case optional pages change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is best explained with an example case:
I added a new RunSelectPage to my mod that allows the player to toggle stickers in the run. It came in between the stake select page and starting the run. However, I wanted a specific stake to skip the sticker page entirely (as it would force all stickers to be enabled). Without this PR, the text for the button that takes you to the next page (or starts the run) would not update properly, staying stuck on what it displayed upon first entering the page.
See attached video for a demonstration of the new behavior (watch the button switch from "Select Stickers >" to "Play"). Note that the button already functioned properly, it's merely a visual issue that this PR addresses.
Video_2026-07-01_21-24-05.mp4
Additional Info: