fix mods being loaded when disabled#1434
Open
frostice482 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there is a specific case where the mod loads when disabled, given the mods are loaded in this order:
CryptidMoreMarioJokers, Amulet (disabled), Cryptid
CryptidMoreMarioJokers requires Amulet, which is disabled, so
check_dependencies(Amulet)returns false. it then requires Cryptid, which then requires Amulet, but this timecheck_dependencies(Amulet)returns true because it's already checked but can_load is not set yet. this causes Cryptid to make Amulet'scan_loadto true, then causing Amulet to load without patches, and Cryptid being able to load while it should be reporting missing Amulet dependenciesthis PR just makes the unloadable mods stays unloadable after it is seen but without can_load being set yet
Additional Info: