Skip to content

fix mods being loaded when disabled#1434

Open
frostice482 wants to merge 1 commit into
Steamodded:mainfrom
frostice482:main
Open

fix mods being loaded when disabled#1434
frostice482 wants to merge 1 commit into
Steamodded:mainfrom
frostice482:main

Conversation

@frostice482

@frostice482 frostice482 commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

there is a specific case where the mod loads when disabled, given the mods are loaded in this order:

CryptidMoreMarioJokers, Amulet (disabled), Cryptid

CryptidMoreMarioJokers requires Amulet, which is disabled, so check_dependencies(Amulet) returns false. it then requires Cryptid, which then requires Amulet, but this time check_dependencies(Amulet) returns true because it's already checked but can_load is not set yet. this causes Cryptid to make Amulet's can_load to true, then causing Amulet to load without patches, and Cryptid being able to load while it should be reporting missing Amulet dependencies

this PR just makes the unloadable mods stays unloadable after it is seen but without can_load being set yet

Additional Info:

  • I didn't modify api's or I've made a PR to the wiki repo.
  • I didn't modify api's or I've updated lsp definitions.
  • I didn't make new lovely files or all new lovely files have appropriate priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant