Only call Blind in_pool for matching blind types#1431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Info:
When generating a small or big blind pool, boss-only blinds were still having their in_pool callbacks executed even
though they could never enter that pool. This can trigger side effects or crashes in mods whose boss blind in_pool
logic assumes it is being checked for the boss pool.
The return value from type-mismatched in_pool calls was already ignored by if not v[blind_type], so this should not
change valid pool membership. It only avoids calling in_pool for blinds that cannot be part of the requested pool.
This changes
SMODS.create_blind_poolsoSMODS.add_to_pool(v)is only called after confirming the blind supportsthe requested
blind_type.Before:
After:
The existing branch order is preserved: