Fix bosses_used compatibility on save load#1430
Open
mleaf233 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Info:
This restores compatibility for
G.GAME.bosses_usedafter loading saves.Custom Small/Big Blinds changed
bosses_usedfrom a flat table into a typed table:{ boss = {}, small = {}, big = {}, }New runs get a metatable that preserves old flat-key access like:
G.GAME.bosses_used["bl_wall"]
However, save serialization does not preserve metatables. After loading a save, old mods that access
G.GAME.bosses_used["bl_*"] receive nil, even when the value exists under G.GAME.bosses_used.boss.
This patch normalizes loaded bosses_used tables and restores the compatibility metatable after Game:start_run loads
save data. keeps the new typed structure while preserving the old flat access pattern used by existing mods built against
vanilla Balatro / earlier SMODS behavior.