S4 refactor + feature additions#493
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #493 +/- ##
==========================================
+ Coverage 82.95% 86.15% +3.19%
==========================================
Files 36 52 +16
Lines 9130 11614 +2484
==========================================
+ Hits 7574 10006 +2432
- Misses 1556 1608 +52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
39df000 to
ede12f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I am adding the last remaining missing features for now:
One important caveat to the LDSC/LDER/HDL implementations is that several of the baseline model annotations are dependent on the population but require a demographic model, recombination map, variant ages and selection coefficients. The ecosystem of packages I'm developing will eventually provide the user with the option to estimate all of the necessary quantities from the same genotype data so that it will eventually be possible for the user to only need to provide the functional annotation parts of the baseline model, but that is for a later time.
The other large refactoring is the implementation of S4 classes. Surprisingly so far this has very minimal impact on the user interface - the only anticipated breakage is for the TWAS parts of the xQTL pipeline that are being moved to pecotmr anyway.