Skip to content

S4 refactor + feature additions#493

Merged
danielnachun merged 6 commits into
mainfrom
s4-refactor
May 25, 2026
Merged

S4 refactor + feature additions#493
danielnachun merged 6 commits into
mainfrom
s4-refactor

Conversation

@danielnachun

Copy link
Copy Markdown
Collaborator

In this PR I am adding the last remaining missing features for now:

  • some alternatives for p-value combination for TWAS
  • some extra RSS methods for LASSO (MCP, SCAD and L0Learn)
  • stratified LDSC, LDER and HDL - assumes the use has the baseline model annotations

One important caveat to the LDSC/LDER/HDL implementations is that several of the baseline model annotations are dependent on the population but require a demographic model, recombination map, variant ages and selection coefficients. The ecosystem of packages I'm developing will eventually provide the user with the option to estimate all of the necessary quantities from the same genotype data so that it will eventually be possible for the user to only need to provide the functional annotation parts of the baseline model, but that is for a later time.

The other large refactoring is the implementation of S4 classes. Surprisingly so far this has very minimal impact on the user interface - the only anticipated breakage is for the TWAS parts of the xQTL pipeline that are being moved to pecotmr anyway.

@codecov

codecov Bot commented May 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.16712% with 525 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.15%. Comparing base (c638868) to head (0a817eb).

Files with missing lines Patch % Lines
R/mash_wrapper.R 3.52% 137 Missing ⚠️
R/genotype_io.R 78.51% 55 Missing ⚠️
R/misc.R 66.92% 42 Missing ⚠️
R/h2_gldsc.R 82.58% 35 Missing ⚠️
R/LD.R 48.48% 34 Missing ⚠️
R/allele_qc.R 3.03% 32 Missing ⚠️
R/mrmash_wrapper.R 0.00% 24 Missing ⚠️
R/gwas_sumstats.R 79.38% 20 Missing ⚠️
R/relatedness_qc.R 81.37% 19 Missing ⚠️
R/h2_hdl.R 91.17% 18 Missing ⚠️
... and 19 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
+ Coverage   82.95%   86.15%   +3.19%     
==========================================
  Files          36       52      +16     
  Lines        9130    11614    +2484     
==========================================
+ Hits         7574    10006    +2432     
- Misses       1556     1608      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danielnachun danielnachun force-pushed the s4-refactor branch 2 times, most recently from 39df000 to ede12f6 Compare May 21, 2026 11:25
@danielnachun danielnachun merged commit 3bc6dc0 into main May 25, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant