feat(index): default to --wait-network-idle for URL rendering#96
Open
aafaq-rashid-comprinno wants to merge 1 commit into
Open
Conversation
Most modern pages are JS-rendered SPAs that produce blank or incomplete
tiles without waiting for network idle. The pixelbrowse skill already
uses this flag, but `pixelrag index build` did not — meaning users
building indexes of dynamic sites got empty/broken tiles silently.
Now the pipeline defaults wait_network_idle=True. Users can opt out
with `ingest: {wait_network_idle: false}` in pixelrag.yaml.
Addresses StarTrail-org#89.
|
@aafaq-rashid-comprinno is attempting to deploy a commit to the andylizf's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #89.
Problem
The
pixelbrowseskill already uses--wait-network-idle(the skill docs even say "Always use it"), butpixelrag index builddid not enable it by default. Users building indexes of JS-rendered sites (React, Next.js, SPAs) got blank or incomplete tiles silently.Fix
One line:
ingest_cfg.setdefault("wait_network_idle", True)inpipelines.py.Users can opt out with:
Why this is safe
loadimmediately — the idle wait adds <500ms