-
Notifications
You must be signed in to change notification settings - Fork 2
Navbar #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Navbar #13
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,9 +1,24 @@ | ||||||
| import { FC } from "react"; | ||||||
| import { NavbarProps as Props } from "./Navbar.types"; | ||||||
| import styles from "./styles/Navbar.module.scss"; | ||||||
| import { FC } from 'react' | ||||||
| import { NavbarProps as Props } from "./Navbar.types" | ||||||
| import styles from "./styles/Navbar.module.scss" | ||||||
|
|
||||||
| const Navbar: FC<Props> = ({}) => { | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Change it like this as suggested |
||||||
| return <div>Navbar here</div>; | ||||||
| return ( | ||||||
| <div> | ||||||
| <div className={styles.navbar}> | ||||||
| <ul> | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't use |
||||||
| <img className={styles.logo} src="public/images/logo.svg"></img> | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| <ul className={styles.left}>Squeryll</ul> | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above. Use |
||||||
| <li><a href="#">Product</a> | ||||||
| <a href="#">Docs</a> | ||||||
| <a href="#">Pricing</a> | ||||||
| <a href="#">Blog</a> | ||||||
| <a href="#">Support</a> | ||||||
| <a href="#">Log in</a> | ||||||
| <button type="button">Sign up</button></li> | ||||||
| </ul> | ||||||
| </div> | ||||||
| </div>); | ||||||
| }; | ||||||
|
|
||||||
| export default Navbar; | ||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| @import url('https://fonts.googleapis.com/css?family=Inter'); | ||
| .navbar{ | ||
| background-color:black; | ||
| top:0; | ||
| left:0; | ||
| width:100%; | ||
| position:fixed; | ||
| font-family: 'Inter'; | ||
| font-style: normal; | ||
| font-weight: 500; | ||
| font-size: 14px; | ||
| } | ||
|
|
||
| .navbar ul.left{ | ||
| color:white; | ||
| float:left; | ||
| margin-left: 40px; | ||
| } | ||
|
|
||
| .navbar button{ | ||
| background-color: #EBAA15; | ||
| text-decoration: none; | ||
| float:right; | ||
| text-align: center; | ||
| border-radius: 25px; | ||
| padding-left:10px; | ||
| padding-right:10px; | ||
| padding-top: 5px; | ||
| padding-bottom: 5px; | ||
| margin-right: 100px; | ||
| margin-top: -3px; | ||
| color:#010200; | ||
| display: flex; | ||
| flex-direction: row; | ||
| align-items: flex-start; | ||
| border:none; | ||
| } | ||
|
|
||
| .navbar a{ | ||
| padding-left: 30px; | ||
| text-decoration:none; | ||
| color:white; | ||
| } | ||
|
|
||
| .navbar a:first-child{ | ||
| padding-left: 300px; | ||
| } | ||
|
|
||
| .navbar a:nth-last-child(2){ | ||
| padding-left:300px; | ||
| padding-right: 30px; | ||
| } | ||
|
|
||
| .logo{ | ||
| position: relative; | ||
| float:left; | ||
| position: absolute; | ||
| top:10px; | ||
| margin-left: 50px; | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,4 +20,4 @@ | |
| "sass": "^1.59.2", | ||
| "typescript": "4.9.5" | ||
| } | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,5 +1,8 @@ | ||||||||||||||
| import Navbar from "../components/commons/Navbar/Navbar" | ||||||||||||||
| export default function Home() { | ||||||||||||||
| return ( | ||||||||||||||
| <div>Squeryll</div> | ||||||||||||||
| <div> | ||||||||||||||
| <Navbar/> | ||||||||||||||
| </div> | ||||||||||||||
|
Comment on lines
+4
to
+6
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
That |
||||||||||||||
| ) | ||||||||||||||
| } | ||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line:
import { NavbarProps as Props } from "./Navbar.types"as we are not using any props for this component