Repository navigation
feat(dockerfile): update dockerfile builds and update dependencies - #168
Merged
Merged
Conversation
- gulp 4 -> 5, gulp-nunjucks/gulp-template 6 are ESM-only so gulpfile is now gulpfile.mjs - Replace gulp-htmlmin (abandoned html-minifier) with gulp-html-minifier-terser - Read images with encoding: false, since gulp 5 decodes files as UTF-8 by default - Migrate Sass @import to @use via sass-migrator
Current live will append a ?v=<sha> to local CSS/JS so Cloudflare and browser caches pick up new builds. We've not rebuilt this in a while, but whenever we do, we ought to make sure to keep cache busting available where needed. CI will always build with a git sha for the arg, while local builds will use a timestamp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We ought to simplify the running of the homepage instead of manual copies from a dist folder to simply push up a docker image that runs it natively. This allows for us to more automatically update dependencies as well.