Remove some full lexsort of spikes when not necesary.#4618
Open
samuelgarcia wants to merge 4 commits into
Open
Remove some full lexsort of spikes when not necesary.#4618samuelgarcia wants to merge 4 commits into
samuelgarcia wants to merge 4 commits into
Conversation
…"sample_index"], spikes["segment_index"]))]
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion: #4606
We do not need strong fulll lexsort in some place because it is not a need.
Important notes : during the version 0.104.0 the zarr format was lexsorting on the fly in init.
This was useless because the lexsort was done before saving in the analyzer create mechanisim.
So we do not need any backward compatibility startegy to handle this.
This should be merge before #4579