Changing fast_mode into n_jobs#4437
Closed
yger wants to merge 7 commits into
Closed
Conversation
for more information, see https://pre-commit.ci
Collaborator
Author
|
The pros for option 1 would be to keep the fast_mode argument and syntax, just relying on globals for optimization. Let's discuss |
for more information, see https://pre-commit.ci
…ts for peaks while clustering (SpikeInterface#4401)" This reverts commit 4c74630.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to rename fast_mode into n_jobs, in order to make everything compatible with HPC (see #4436).
However, there are two options:
In all cases, we should highlight that using n_jobs > 1 makes the results slightly underterministic