Optimizations: faster waveforms/templates and seeding iterative_isosplit properly#4402
Merged
Conversation
…thread_an_no_nogil
for more information, see https://pre-commit.ci
…erface into thread_an_no_nogil
This reverts commit a6284e8.
yger
added
enhancement
for more information, see https://pre-commit.ci
Member
|
I do not believe the 15% but if it make you happy. lets merge. |
samuelgarcia
approved these changes
Mar 11, 2026
samuelgarcia
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor optimizations of the way waveforms are computed by the analyzer both for templates and waveforms. We can gain 15% speedup by slightly less operation.
Plus seeding of iterative_isosplit is not perfect at the momentn because seeds are not propagated at the split level