Implement select_sorting_periods in core#4316
Merged
samuelgarcia merged 22 commits intoJan 16, 2026
Merged
Conversation
Co-authored-by: Chris Halcrow <57948917+chrishalcrow@users.noreply.github.com>
Co-authored-by: Chris Halcrow <57948917+chrishalcrow@users.noreply.github.com>
…select_sorting_periods_core
alejoe91
added a commit
to alejoe91/spikeinterface
that referenced
this pull request
Jan 13, 2026
| spike_vector = sorting.to_spike_vector() | ||
| spike_vector_list = sorting.to_spike_vector(concatenated=False) | ||
| keep_mask = np.zeros(len(spike_vector), dtype=bool) | ||
| all_global_indices = spike_vector_to_indices(spike_vector_list, unit_ids=sorting.unit_ids, absolute_index=True) |
Member
There was a problem hiding this comment.
Should this plus 249 use get_spike_vector_to_indices?
| SharedMemorySorting, | ||
| NpzFolderSorting, | ||
| NumpyFolderSorting, | ||
| generate_ground_truth_recording, |
Member
There was a problem hiding this comment.
why do we need this in testing sorting ?
…select_sorting_periods_core
samuelgarcia
approved these changes
Jan 16, 2026
Member
|
Et voilà! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor based on #4314