add keyboard search feature - #63
iamrahulrnair wants to merge 8 commits into
Conversation
|
Hi can i get a review on this please :-^ |
| const [new_array,setNew_array]=useState([]) | ||
| let [counter,setCounter]=useState(0) |
There was a problem hiding this comment.
Can we give more meaningful names to these states like: keyCounter and something more apt for new_array
Sparsh1212
left a comment
Sparsh1212
left a comment
There was a problem hiding this comment.
Just some nit fixes are needed in naming the variables. Also, I need to take a proper look at your added comment. Rest everything seems fine to me.
Can you also add a demo video as a proof of working?
|
Hi, I have renamed the variables, and my prettier have added some auto formatting, that wont have impact on the application. changed single quote to double quote that is all, 9c819518-4870-4bd5-93fb-b4f32db959dc.mp4l |
Sparsh1212
left a comment
Sparsh1212
left a comment
There was a problem hiding this comment.
Although it won't have any effect on the application still we want the codebase to be consistent throughout. Please make sure you revert all the formatting changes from this PR. You can take your time, no rush.
|
changed the quotes, and semi colon. although its a good convention to include semi-colon and double quotes to strings and single quotes for jsx , thanks :-) |
Sparsh1212
left a comment
Sparsh1212
left a comment
There was a problem hiding this comment.
Some of the formatting changes are still not reverted like semicolons and commas. Please make sure those are reverted too.
This branch has not been deployed
2 participants
Added Keyboard search functionality,User can search for a keyword and from the suggestion list user can fill the input with up and down arrow keys.