WindowScreen & UIComponent: Improve key input handling#177
Draft
Traben-0 wants to merge 43 commits into
Draft
Conversation
…off keyType functions into key and character event functions
Traben-0
commented
Mar 29, 2026
| kotlinx-coroutines = "1.5.2" | ||
| jetbrains-annotations = "23.0.0" | ||
| universalcraft = "466" | ||
| universalcraft = "474+feature-em-1645-closing-uscreen-via-esc-on-119-puts-you-in-the-menu-rather" |
Traben-0
commented
Mar 29, 2026
Johni0702
requested changes
Mar 31, 2026
Johni0702
requested changes
Apr 8, 2026
Johni0702
reviewed
Apr 9, 2026
Johni0702
requested changes
Apr 27, 2026
| return true | ||
| } else if (keyCode == UKeyboard.KEY_ENTER) { // Enter | ||
| onEnterPressed() | ||
| onEnterPressed(modifiers) |
Contributor
There was a problem hiding this comment.
issue: Breaking change. If a third-party subclass overrides the old method, their code will now no longer be called.
Could make this conditional on ElementaVersion.V12.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: UniversalCraft#125
Implements the new input functions replacing the old
keyType(keycode, character)functions with equivalentkeyType(UIKeyEvent)&charType(UICharEvent)functions, under the newElementaVersion.v12.