Skip to content

remove computed field from instruction add one remove field command f… #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oswald-logicLoop merged 3 commits into from
Jun 29, 2026
Merged

remove computed field from instruction add one remove field command f… #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf12cad
remove computed field from instruction add one remove field command f…
saibazkhan-maker Jun 23, 2026
a5d1a25
Merge branch 'dev' of github.com:SolidXAI/core into remove-computed-f…
saibazkhan-maker Jun 24, 2026
de3501b
refactor and add migration command
saibazkhan-maker Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 81 additions & 0 deletions src/commands/migrate-removed-fields.command.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
import { Logger } from "@nestjs/common";
import { Command, CommandRunner, Option } from "nest-commander";
import { RemovedFieldMigrationService } from "src/services/removed-field-migration.service";
import { CommandError } from "./helper";
import { ModelMetadataService } from "src/services/model-metadata.service";

interface CommandOptions {
name: string;
dryRun?: boolean;
}

@Command({
name: "migrate-removed-fields",
description: "Drops live database artifacts for fields marked for removal and cleans the related metadata.",
})
export class MigrateRemovedFieldsCommand extends CommandRunner {
constructor(
private readonly removedFieldMigrationService: RemovedFieldMigrationService,
private readonly modelMetadataService: ModelMetadataService,

) {
super();
}

private readonly logger = new Logger(MigrateRemovedFieldsCommand.name);

async run(_passedParam: string[], options?: CommandOptions): Promise<void> {
const errors = this.validate(options);
if (errors.length) {
errors.forEach((error) => this.logger.error(error));
return;
}

const dryRun = options?.dryRun ?? true;

// STEP 1: Capture fields BEFORE migration deletes metadata
// const model = await this.modelMetadataService.findOneByUserKey(
// options.name,
// ["module", "fields"],
// );

// const fieldsForRemoval = model.fields.filter(
// field => field.isMarkedForRemoval,
// );

// // STEP 2: Run remove-fields schematic first
// if (!dryRun && fieldsForRemoval.length > 0) {
// // await this.modelMetadataService.executeRemoveFieldsOnly(options.name,fieldsForRemoval.map(f => f.name),false,);
// await this.modelMetadataService.executeRemoveFieldsWithModel(model, fieldsForRemoval.map(f => f.name),false,);
// }

// STEP 3: Then perform DB + metadata cleanup
const result = await this.removedFieldMigrationService.migrateMarkedFields(options.name, dryRun,);

result.operations.forEach((operation) => this.logger.log(operation));
}

@Option({
flags: "-n, --name <model name>",
description: "Model name (singularName) from the ss_model_metadata table",
})
parseName(val: string): string {
return val;
}

@Option({
flags: "-d, --dryRun [dry run]",
description: "Dry run the command",
})
parseDryRun(val: string): boolean {
this.logger.debug(`Dry run : ${val}`);
return val === "false" ? false : true;
}

private validate(options: CommandOptions): CommandError[] {
if (!options?.name) {
return [new CommandError("Model Name is required")];
}
return [];
}
}
140 changes: 109 additions & 31 deletions src/seeders/seed-data/solid-core-metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8737,12 +8737,15 @@
48
],
"enableGlobalSearch": true,
"create": true,
"edit": true,
"create": false,
"edit": false,
"delete": true,
"import": false,
"export": false,
"allowedViews": [
"list",
"card"
"card",
"tree"
]
},
"children": [
Expand Down Expand Up @@ -9003,7 +9006,13 @@
"enableGlobalSearch": true,
"create": false,
"edit": false,
"delete": false
"delete": false,
"import": false,
"export": false,
"allowedViews": [
"list",
"tree"
]
},
"children": [
{
Expand Down Expand Up @@ -10095,15 +10104,11 @@
"swimlanesCount": 5,
"recordsInSwimlane": 10,
"enableGlobalSearch": true,
"create": true,
"edit": true,
"delete": true,
"create": false,
"edit": false,
"delete": false,
"groupBy": "stage",
"draggable": false,
"allowedViews": [
"list",
"kanban"
]
"draggable": false
},
"children": [
{
Expand Down Expand Up @@ -11929,7 +11934,11 @@
"edit": false,
"delete": false,
"import": false,
"export": false
"export": false,
"allowedViews": [
"list",
"tree"
]
},
"children": [
{
Expand Down Expand Up @@ -13424,7 +13433,13 @@
"enableGlobalSearch": true,
"create": false,
"edit": true,
"delete": false
"delete": false,
"import": false,
"export": false,
"allowedViews": [
"list",
"tree"
]
},
"children": [
{
Expand Down Expand Up @@ -13499,7 +13514,13 @@
"enableGlobalSearch": true,
"create": false,
"edit": false,
"delete": false
"delete": false,
"import": false,
"export": false,
"allowedViews": [
"list",
"tree"
]
},
"children": [
{
Expand Down Expand Up @@ -13583,7 +13604,13 @@
"enableGlobalSearch": true,
"create": false,
"edit": false,
"delete": false
"delete": false,
"import": false,
"export": false,
"allowedViews": [
"list",
"tree"
]
},
"children": [
{
Expand Down Expand Up @@ -13645,7 +13672,13 @@
"enableGlobalSearch": true,
"create": false,
"edit": false,
"delete": false
"delete": false,
"import": false,
"export": false,
"allowedViews": [
"list",
"tree"
]
},
"children": [
{
Expand Down Expand Up @@ -13714,7 +13747,13 @@
"enableGlobalSearch": true,
"create": false,
"edit": false,
"delete": false
"delete": true,
"import": false,
"export": false,
"allowedViews": [
"list",
"tree"
]
},
"children": [
{
Expand Down Expand Up @@ -13784,7 +13823,14 @@
"enableGlobalSearch": true,
"create": false,
"edit": false,
"delete": false
"delete": true,
"import": false,
"export": false,
"allowedViews": [
"list",
"card",
"tree"
]
},
"children": [
{
Expand Down Expand Up @@ -13850,11 +13896,14 @@
50
],
"enableGlobalSearch": true,
"create": false,
"edit": false,
"delete": false,
"import": false,
"export": false
"create": true,
"edit": true,
"delete": true,
"import": true,
"export": true,
"allowedViews": [
"list"
]
},
"children": [
{
Expand Down Expand Up @@ -13889,7 +13938,11 @@
"edit": false,
"delete": false,
"import": false,
"export": false
"export": false,
"allowedViews": [
"list",
"tree"
]
},
"children": [
{
Expand Down Expand Up @@ -13951,7 +14004,11 @@
"edit": false,
"delete": false,
"import": false,
"export": false
"export": false,
"allowedViews": [
"list",
"tree"
]
},
"children": [
{
Expand Down Expand Up @@ -14020,7 +14077,11 @@
"edit": true,
"delete": true,
"import": true,
"export": true
"export": true,
"allowedViews": [
"list",
"tree"
]
},
"children": [
{
Expand Down Expand Up @@ -14080,7 +14141,11 @@
"edit": false,
"delete": false,
"import": false,
"export": false
"export": false,
"allowedViews": [
"list",
"tree"
]
},
"children": [
{
Expand Down Expand Up @@ -14140,7 +14205,11 @@
"edit": false,
"delete": false,
"import": false,
"export": false
"export": false,
"allowedViews": [
"list",
"tree"
]
},
"children": [
{
Expand Down Expand Up @@ -14210,7 +14279,11 @@
"edit": false,
"delete": false,
"import": false,
"export": false
"export": false,
"allowedViews": [
"list",
"tree"
]
},
"children": [
{
Expand Down Expand Up @@ -14279,7 +14352,12 @@
"enableGlobalSearch": true,
"create": true,
"edit": true,
"delete": true
"delete": true,
"import": true,
"export": true,
"allowedViews": [
"list"
]
},
"children": [
{
Expand Down
Loading