Skip to content

fix bugs found from running e2e tests - #471

Draft
SharonStrats wants to merge 1 commit into
stagingfrom
fix/profile-bugs-from-tests
Draft

SharonStrats wants to merge 1 commit into
stagingfrom
fix/profile-bugs-from-tests

Conversation

@SharonStrats

@SharonStrats SharonStrats commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

I just want to check this before changing it from a draft.

Things it found that I need to confirm if correct or not
1 The heading mutation updated vcard:fn, but left the older foaf:name value unchanged. The displayed profile heading resolves from foaf:name, so RDF persisted but the visible heading stayed stale. * This one i don't think is correct...

  1. when adding a 3rd value for languages and also reording of social accounts etc it found that not everything was getting written so it changed to push and made another change... I need to check this locally to see if it works in the browser. - Note: When passing multiple arguments to unshift(), they are inserted as a single chunk, preserving the order you passed them in. so i need to double check if we still get the behavior we want because with languages and social the order matters.

@SharonStrats
SharonStrats requested a balanced review from Copilot October 11, 2026 11:22
@SharonStrats SharonStrats self-assigned this Oct 11, 2026
@SharonStrats SharonStrats added the bug Something isn't working label Oct 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Full-document PUTs can erase unloaded profile data, and nested RDF collections remain incompletely serialized.

3 open findings
What changed in this PR

Fixes profile editing bugs uncovered by end-to-end tests.

Changes:

  • Appends new language and social rows correctly.
  • Synchronizes FOAF names across heading and social mutations.
  • Expands RDF collections before full-document serialization and updates dependencies/tests.
File Description
src/​sections/​languages/​LanguageEditDialog.ts Appends and focuses new language rows.
src/​sections/​social/​SocialEditDialog.ts Appends and focuses new social rows.
src/​sections/​heading/​mutations.ts Synchronizes foaf:name.
src/​sections/​social/​mutations.ts Stores and replaces account names.
src/​sections/​shared/​rdfMutationHelpers.ts Expands RDF collections for PUT serialization.
test/​dialog.accessibility.test.ts Tests appended language rows.
test/​sections/​heading.selectors-mutations.test.ts Tests name synchronization and removal.
test/​sections/​languages.selectors-mutations.test.ts Verifies expanded language lists.
test/​sections/​social.selectors-mutations.test.ts Verifies account names and expanded lists.
package-lock.json Updates the toolkit lock entry.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

const serializationStore = graph() as LiveStore
nextStatements.forEach((statement) => {
serializationStore.add(statement.subject, statement.predicate, statement.object, statement.why)
if (statement.object.termType !== 'Collection') {
serializationStore.add(
listNode,
sym('http://www.w3.org/1999/02/22-rdf-syntax-ns#first'),
element,

const accountName = store.any(entryNode, ns.foaf('accountName'), null, doc)
expect(accountName?.value).toBe('sharon')
expect(store.any(entryNode, ns.foaf('name'), null, doc)?.value).toBe('Github')
@SharonStrats

Copy link
Copy Markdown
Contributor Author

@timea-solid this one I would like to look into further if I get some time before the release since it suggested it was broken and the change isn't too big. but i have to double check a few things for myself manually to know for sure if this is an acceptable change. using push instead of unshift may affect ordering.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants