Repository navigation
fix bugs found from running e2e tests - #471
Draft
SharonStrats wants to merge 1 commit into
Draft
SharonStrats wants to merge 1 commit into
SharonStrats wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Full-document PUTs can erase unloaded profile data, and nested RDF collections remain incompletely serialized.
3 open findings
What changed in this PR
Fixes profile editing bugs uncovered by end-to-end tests.
Changes:
- Appends new language and social rows correctly.
- Synchronizes FOAF names across heading and social mutations.
- Expands RDF collections before full-document serialization and updates dependencies/tests.
| File | Description |
|---|---|
src/sections/languages/LanguageEditDialog.ts |
Appends and focuses new language rows. |
src/sections/social/SocialEditDialog.ts |
Appends and focuses new social rows. |
src/sections/heading/mutations.ts |
Synchronizes foaf:name. |
src/sections/social/mutations.ts |
Stores and replaces account names. |
src/sections/shared/rdfMutationHelpers.ts |
Expands RDF collections for PUT serialization. |
test/dialog.accessibility.test.ts |
Tests appended language rows. |
test/sections/heading.selectors-mutations.test.ts |
Tests name synchronization and removal. |
test/sections/languages.selectors-mutations.test.ts |
Verifies expanded language lists. |
test/sections/social.selectors-mutations.test.ts |
Verifies account names and expanded lists. |
package-lock.json |
Updates the toolkit lock entry. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| const serializationStore = graph() as LiveStore | ||
| nextStatements.forEach((statement) => { | ||
| serializationStore.add(statement.subject, statement.predicate, statement.object, statement.why) | ||
| if (statement.object.termType !== 'Collection') { |
| serializationStore.add( | ||
| listNode, | ||
| sym('http://www.w3.org/1999/02/22-rdf-syntax-ns#first'), | ||
| element, |
|
|
||
| const accountName = store.any(entryNode, ns.foaf('accountName'), null, doc) | ||
| expect(accountName?.value).toBe('sharon') | ||
| expect(store.any(entryNode, ns.foaf('name'), null, doc)?.value).toBe('Github') |
Contributor
Author
|
@timea-solid this one I would like to look into further if I get some time before the release since it suggested it was broken and the change isn't too big. but i have to double check a few things for myself manually to know for sure if this is an acceptable change. using push instead of unshift may affect ordering. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


I just want to check this before changing it from a draft.
Things it found that I need to confirm if correct or not
1 The heading mutation updated vcard:fn, but left the older foaf:name value unchanged. The displayed profile heading resolves from foaf:name, so RDF persisted but the visible heading stayed stale. * This one i don't think is correct...