Skip to content

Use the profile service from solid-logic - #470

Closed
SharonStrats wants to merge 1 commit into
stagingfrom
feat/use-profilelogic
Closed

SharonStrats wants to merge 1 commit into
stagingfrom
feat/use-profilelogic

Conversation

@SharonStrats

Copy link
Copy Markdown
Contributor

Just trying this out... we can decide not to use it.

Prompt: Remove all the selection and mutation code for all sections and use
the profile service from solid-logic. Make sure to remove tests.

Co-authored-by: GPT-5.6 Luna <gpt-5.6-luna@openai.com>
@SharonStrats
SharonStrats requested a balanced review from Copilot October 11, 2026 05:54
@SharonStrats SharonStrats self-assigned this Oct 11, 2026
@SharonStrats SharonStrats added the enhancement New feature or request label Oct 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The locked solid-logic 6.0.0 release does not provide the profile-service APIs now called throughout the application.

1 open finding
What changed in this PR

Moves profile selection and mutation logic from profile-pane into solid-logic and adopts its sourceNode data contract.

Changes:

  • Replaces local profile services with solidLogicSingleton.profile.
  • Renames entryNode to sourceNode.
  • Removes migrated implementations/tests and updates remaining tests.
File Description
test/​SocialPresenter.spec.ts Removes local social presenter tests.
test/​social-card.accessibility.test.ts Uses sourceNode.
test/​sections/​social.selectors-mutations.test.ts Removes migrated social tests.
test/​sections/​social.section.test.ts Uses sourceNode.
test/​sections/​skills.selectors-mutations.test.ts Removes migrated skills tests.
test/​sections/​skills.section.test.ts Uses sourceNode.
test/​sections/​shared.helpers.test.ts Updates row-state fixtures.
test/​sections/​resume.section.test.ts Uses sourceNode.
test/​sections/​resume-organization-options.test.ts Adds organization filtering coverage.
test/​sections/​projects.selectors-mutations.test.ts Removes migrated project tests.
test/​sections/​projects.section.test.ts Uses sourceNode.
test/​sections/​languages.section.test.ts Uses sourceNode.
test/​sections/​heading.viewer-actions.integration.test.ts Updates profile fixture fields.
test/​sections/​heading.selectors-mutations.test.ts Removes migrated heading tests.
test/​sections/​heading.section.test.ts Uses sourceNode.
test/​sections/​heading.mutations.id-node.test.ts Removes local mutation test.
test/​sections/​education.selectors-mutations.test.ts Removes migrated education tests.
test/​sections/​education.section.test.ts Uses sourceNode.
test/​sections/​contact-info.selectors-mutations.test.ts Removes migrated contact tests.
test/​sections/​contact-info.section.test.ts Uses sourceNode.
test/​sections/​bio.selectors-mutations.test.ts Removes migrated bio tests.
test/​sections/​bio.section.test.ts Uses sourceNode.
test/​sections/​accessibility-variants.test.ts Updates shared accessibility fixtures.
test/​profile-view.composition.test.ts Uses singleton-backed presenter.
test/​profile-view-model-presenter.integration.test.ts Removes local selector mocking.
test/​presenter.spec.ts Removes local heading presenter tests.
test/​heading-edit-dialog.test.ts Spies on profile service mutations.
test/​heading-actions-layout.test.ts Removes solid-logic store mock.
test/​edit-dialog-phone-values.test.ts Spies on profile service mutations.
test/​dialog.accessibility.test.ts Uses singleton profile store.
test/​CVPresenter.spec.ts Removes local CV presenter tests.
test/​cv-card.accessibility.test.ts Uses sourceNode.
src/​sections/​social/​types.ts Renames social node fields.
src/​sections/​social/​SocialEditDialog.ts Uses profile mutation service.
src/​sections/​social/​selectors.ts Removes local selector.
src/​sections/​social/​mutations.ts Removes local mutations.
src/​sections/​social/​helpers.ts Adds presentation icon resolution.
src/​sections/​skills/​types.ts Renames skills node fields.
src/​sections/​skills/​SkillsSection.ts Uses profile mutation service.
src/​sections/​skills/​SkillsEditDialog.ts Uses profile mutation service.
src/​sections/​skills/​selectors.ts Removes local selector.
src/​sections/​skills/​mutations.ts Removes local mutations.
src/​sections/​shared/​rowState.ts Tracks rows by sourceNode.
src/​sections/​shared/​rdfMutationHelpers.ts Renames node lookup parameter.
src/​sections/​resume/​types.ts Renames resume node fields.
src/​sections/​resume/​selectors.ts Removes local selector.
src/​sections/​resume/​ResumeEditDialog.ts Uses profile mutation service.
src/​sections/​resume/​mutations.ts Removes local mutations.
src/​sections/​projects/​types.ts Renames project node fields.
src/​sections/​projects/​selectors.ts Removes local selector.
src/​sections/​projects/​ProjectSection.ts Uses profile mutation service.
src/​sections/​projects/​ProjectEditDialog.ts Uses profile mutation service.
src/​sections/​projects/​mutations.ts Removes local mutations.
src/​sections/​languages/​types.ts Renames language node fields.
src/​sections/​languages/​selectors.ts Removes local selector.
src/​sections/​languages/​mutations.ts Removes local mutations.
src/​sections/​languages/​LanguageEditDialog.ts Uses profile mutation service.
src/​sections/​heading/​types.ts Renames heading node fields.
src/​sections/​heading/​selectors.ts Removes local selector.
src/​sections/​heading/​mutations.ts Removes local mutations.
src/​sections/​heading/​HeadingEditDialog.ts Uses profile mutation service.
src/​sections/​education/​types.ts Renames education node fields.
src/​sections/​education/​selectors.ts Removes local selector.
src/​sections/​education/​mutations.ts Removes local mutations.
src/​sections/​education/​EducationEditDialog.ts Uses profile mutation service.
src/​sections/​contactInfo/​types.ts Renames contact node fields.
src/​sections/​contactInfo/​selectors.ts Removes local selector.
src/​sections/​contactInfo/​mutations.ts Removes local mutations.
src/​sections/​contactInfo/​ContactInfoSection.ts Resolves contacts via sourceNode.
src/​sections/​contactInfo/​ContactInfoEditDialog.ts Uses profile mutation service.
src/​sections/​bio/​types.ts Renames bio node fields.
src/​sections/​bio/​selectors.ts Removes local selector.
src/​sections/​bio/​mutations.ts Removes local mutations.
src/​sections/​bio/​BioEditDialog.ts Uses profile mutation service.
src/​ProfileViewModelPresenter.ts Aggregates solid-logic profile getters.
src/​ProfileView.ts Uses singleton-backed presenter signature.
package-lock.json Updates solidos-toolkit metadata.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

const cvDetails = presentCV(subject, store)
export async function presentProfileViewModel(subject: NamedNode): Promise<ProfileViewModel> {
const { profile } = solidLogicSingleton
const profileDetails = profile.getHeading(subject)
@SharonStrats

Copy link
Copy Markdown
Contributor Author

@timea-solid I was just playing around over the weekend. If we want to move profile logic to solid-logic we could use this, but I'm going to close for now. the profile addition I made to solid-logic was not passing the e2e tests so I need to leave it for now. Basically we have a problem with handling "ordering" in general that's one big reason that the current mutations are a bit "funny". This is for social and for languages and some time will need to be spent figuring out the right way to do them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants