Repository navigation
Wiring in the new heading component from solid-panes - #469
Conversation
…section. When i edit that i want the profile heading to be refreshed. Co-authored-by: GitHub Copilot (auto) <copilot@github.com>
…6.0.0 solid-ui@5.0.1 pane-registry@5.0.1 chat-pane@4.0.0)
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Watch mode omits required declarations, and the described solid-panes heading integration is not implemented.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Adds integration APIs and save notifications to support an externally hosted profile heading.
Changes:
- Exposes heading-related APIs and emits
profile-pane-savedevents. - Adds event behavior tests and documentation.
- Updates watch-mode build configuration and package version.
| File | Description |
|---|---|
src/index.ts |
Exports heading APIs and dispatches save events. |
test/profile-saved-event.test.ts |
Tests save-event behavior. |
README.md |
Documents the event contract. |
vite.config.mts |
Adjusts watch-mode plugins and outputs. |
package.json |
Bumps the package version. |
package-lock.json |
Synchronizes version and lock metadata. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| if (Array.isArray(resolved)) { | ||
| return (await Promise.all(resolved.map(watchPlugins))).flat(); | ||
| } | ||
| return /dts/i.test(resolved.name) ? [] : [resolved]; |
…6.0.0 solid-ui@5.0.1 pane-registry@5.0.1 chat-pane@4.0.0)
…6.0.0 solid-ui@5.0.1 pane-registry@5.0.1 chat-pane@4.0.0)
There was a problem hiding this comment.
🟡 Changes recommended
Save events can fire without mutations, keyboard submission regresses, and the heading removal leaves layout and accessibility-test gaps.
6 open findings
Obsolete grid row assignments add unintended profile spacing · New False save notifications emitted for unchanged forms · New Removing submit control breaks implicit Enter submission · New Watch mode omits declaration generation and leaves stale TypeScript types ProfileView still renders the local heading instead of the new component axe suppression hides all custom buttons from accessibility tests · New
🧠 Review effort: Balanced
…istry@5.0.2-0) (latest: rdflib@2.4.1 solid-ui@5.0.1 chat-pane@4.0.0)
…istry@5.0.2-0) (latest: rdflib@2.4.1 solid-ui@5.0.1 chat-pane@4.0.0)
| </svg> | ||
| ` | ||
|
No newline at end of file |
||
| const registerIcon = (tagName: string, IconClass: any) => { |
There was a problem hiding this comment.
Maybe this was an intermediate step for now... I think we are better off just adding the icons where they are used and styling them with css.
There was a problem hiding this comment.
The icons repeat in different files that is why it is like this.
| import { RowStatus } from '../shared/types' | ||
| import { MutationOps } from '../shared/types' | ||
| import type { AddressDetails, ContactAddressRow, ContactPointRow, PointDetails } from '../contactInfo/types' | ||
| import type { AddressDetails, PointDetails } from '../contactInfo/types' |
There was a problem hiding this comment.
I'm wondering maybe you can delete this file too and just import from contactInfo where they are used.
There was a problem hiding this comment.
Good catch, there were more problems here. I fied them now.
| if (target.isConnected) { | ||
| wasConnected = true | ||
| } else if (wasConnected) { | ||
| context.dom.removeEventListener(PROFILE_HEADING_SAVED_EVENT, handleHeadingSaved) |
There was a problem hiding this comment.
wasConnected is initially false and is only set when an event arrives while the target is connected. If the pane is rendered, mounted, and removed without any heading event occurring—which is a normal lifecycle—the listener remains registered permanently.
you could use a MutationObserver to watch for the target’s removal
| "solid-logic": "^6.0.0", | ||
| "solidos-toolkit": "dev", | ||
| "solid-logic": "^6.0.1-0", | ||
| "solidos-toolkit": "1.0.0-dev.c11da40967c5d278451118142650415d688d8d4c", |
There was a problem hiding this comment.
I am not sure if this is the correct approach, but what I did was to change this to this exact version do a npm i so it updates the lock file, but then so that it works in the future the way I think it is intended with the chore I changed it back to just 'dev' here.
|
|
||
|  | ||
|
|
||
| ## Profile updates |
There was a problem hiding this comment.
Nice that you added this detail to the readme.
| import { defineConfig } from "vitest/config"; | ||
| import Icons from "unplugin-icons/vite"; | ||
|
|
||
| const isWatch = process.argv.includes("--watch"); |
There was a problem hiding this comment.
You shouldn't need this now because the new toolkit has this automatically.
SharonStrats
left a comment
There was a problem hiding this comment.
Looks great! I like how it works and it looks very nice.
I left some overall comments, here is a summary of my thoughts:
before merge i think you should:
- remove the watch behavior from the vite config since it is handled in the toolkit now
- change the toolkit back to 'dev' in the package json, just a gut feeling on this
- probably you should add the mutation observer, this was feedback I received from asking ai locally just FYI but I think it makes sense.
not that important - there were a couple other things about the icons and the heading type file that I think would be nice to change but we could just change that later when we use more of the lucide icons.
…istry@5.0.2-0) (latest: rdflib@2.4.1 solid-ui@5.0.1 chat-pane@4.0.0)
…istry@5.0.2-0) (latest: rdflib@2.4.1 solid-ui@5.0.1 chat-pane@4.0.0)


This is moving the heading section to solid-panes. See: SolidOS/solid-panes#726