Skip to content

Wiring in the new heading component from solid-panes - #469

Merged
timea-solid merged 23 commits into
stagingfrom
headingComponent
Oct 13, 2026
Merged

timea-solid merged 23 commits into
stagingfrom
headingComponent

Conversation

@timea-solid

@timea-solid timea-solid commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

This is moving the heading section to solid-panes. See: SolidOS/solid-panes#726

…section. When i edit that i want the profile heading to be refreshed.

Co-authored-by: GitHub Copilot (auto) <copilot@github.com>
@timea-solid timea-solid self-assigned this Oct 7, 2026
Copilot AI balanced review requested due to automatic review settings October 7, 2026 12:41
…6.0.0 solid-ui@5.0.1 pane-registry@5.0.1 chat-pane@4.0.0)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Watch mode omits required declarations, and the described solid-panes heading integration is not implemented.

Review effort: Balanced
Findings: 2 Medium severity

Open (2)
What changed in this PR

Adds integration APIs and save notifications to support an externally hosted profile heading.

Changes:

  • Exposes heading-related APIs and emits profile-pane-saved events.
  • Adds event behavior tests and documentation.
  • Updates watch-mode build configuration and package version.
File Description
src/​index.ts Exports heading APIs and dispatches save events.
test/​profile-saved-event.test.ts Tests save-event behavior.
README.md Documents the event contract.
vite.config.mts Adjusts watch-mode plugins and outputs.
package.json Bumps the package version.
package-lock.json Synchronizes version and lock metadata.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/index.ts Resolved
Comment thread vite.config.mts Outdated
if (Array.isArray(resolved)) {
return (await Promise.all(resolved.map(watchPlugins))).flat();
}
return /dts/i.test(resolved.name) ? [] : [resolved];
@timea-solid
timea-solid marked this pull request as draft October 7, 2026 13:16
@timea-solid timea-solid moved this to In progress in SolidOS NLNet UI Oct 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/ProfileView.ts Resolved
Comment thread src/index.ts Resolved
Comment thread src/ui/dialog.ts Resolved
Comment thread test/helpers/runAxe.ts Resolved
@timea-solid
timea-solid marked this pull request as ready for review October 9, 2026 14:55
@timea-solid timea-solid moved this from In progress to In review in SolidOS NLNet UI Oct 9, 2026
</svg>
`

No newline at end of file
const registerIcon = (tagName: string, IconClass: any) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this was an intermediate step for now... I think we are better off just adding the icons where they are used and styling them with css.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons repeat in different files that is why it is like this.

Comment thread src/sections/heading/types.ts Outdated
import { RowStatus } from '../shared/types'
import { MutationOps } from '../shared/types'
import type { AddressDetails, ContactAddressRow, ContactPointRow, PointDetails } from '../contactInfo/types'
import type { AddressDetails, PointDetails } from '../contactInfo/types'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering maybe you can delete this file too and just import from contactInfo where they are used.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, there were more problems here. I fied them now.

Comment thread src/index.ts Outdated
if (target.isConnected) {
wasConnected = true
} else if (wasConnected) {
context.dom.removeEventListener(PROFILE_HEADING_SAVED_EVENT, handleHeadingSaved)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasConnected is initially false and is only set when an event arrives while the target is connected. If the pane is rendered, mounted, and removed without any heading event occurring—which is a normal lifecycle—the listener remains registered permanently.

you could use a MutationObserver to watch for the target’s removal

Comment thread package.json Outdated
"solid-logic": "^6.0.0",
"solidos-toolkit": "dev",
"solid-logic": "^6.0.1-0",
"solidos-toolkit": "1.0.0-dev.c11da40967c5d278451118142650415d688d8d4c",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this is the correct approach, but what I did was to change this to this exact version do a npm i so it updates the lock file, but then so that it works in the future the way I think it is intended with the chore I changed it back to just 'dev' here.

Comment thread README.md

![CI](https://github.com/solid/profile-pane/workflows/CI/badge.svg)

## Profile updates

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that you added this detail to the readme.

Comment thread vite.config.mts Outdated
import { defineConfig } from "vitest/config";
import Icons from "unplugin-icons/vite";

const isWatch = process.argv.includes("--watch");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't need this now because the new toolkit has this automatically.

@SharonStrats SharonStrats left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I like how it works and it looks very nice.

I left some overall comments, here is a summary of my thoughts:
before merge i think you should:

  • remove the watch behavior from the vite config since it is handled in the toolkit now
  • change the toolkit back to 'dev' in the package json, just a gut feeling on this
  • probably you should add the mutation observer, this was feedback I received from asking ai locally just FYI but I think it makes sense.
    not that important
  • there were a couple other things about the icons and the heading type file that I think would be nice to change but we could just change that later when we use more of the lucide icons.

timea-solid and others added 4 commits October 13, 2026 21:49
…istry@5.0.2-0) (latest: rdflib@2.4.1 solid-ui@5.0.1 chat-pane@4.0.0)
…istry@5.0.2-0) (latest: rdflib@2.4.1 solid-ui@5.0.1 chat-pane@4.0.0)
@timea-solid
timea-solid merged commit 5a72940 into staging Oct 13, 2026
8 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in SolidOS NLNet UI Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants