Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(manifest): stream Coana output and surface the real failure reason #1353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
fix(manifest): stream Coana output and surface the real failure reason #1353
Changes from 1 commit
0a6162ed3d3b8e6ac680fFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
`socket manifest {gradle,kotlin,scala}` delegate Socket facts generation to the Coana CLI via spawnCoanaDlx, passing `{ stdio: 'inherit' }` so the build-tool and Coana output streams to the user. On the dlx path that stdio was silently dropped: shadowNpmBase configures the child's stdio from its `options` arg, not the registry-spawn `extra` arg, so Coana ran piped and its output — including the actual failure reason — never reached the user. A generation failure then collapsed to an unhelpful "Coana command failed (exit code 1): command failed" with no detail. - spawnCoanaDlx now promotes the requested stdio (from spawnExtra, falling back to options) into the dlx launcher options, aligning the dlx path with the local-path and npm-install branches that already honor spawnExtra.stdio. - buildDlxErrorResult falls back to captured stdout when stderr is empty, since Coana logs some failures (e.g. unresolved dependencies) to stdout. Add regression tests and bump the CLI to 1.1.115.Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Uh oh!
There was an error while loading. Please reload this page.