Skip to content

Avoid square qq (use axline) #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielward27 merged 1 commit into from
Sep 4, 2025
Merged

Avoid square qq (use axline) #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions pymgcv/plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,7 +756,7 @@ def qq(
qq_fun: Callable[[AbstractGAM], QQResult] = qq_simulate,
scatter_kwargs: dict | None = None,
fill_between_kwargs: dict | None = None,
plot_kwargs: dict | None = None,
axline_kwargs: dict | None = None,
ax: Axes | None = None,
) -> Axes:
"""A Q-Q plot of deviance residuals.
Expand All @@ -773,7 +773,7 @@ def qq(
scatter_kwargs: Key word arguments passed to `matplotlib.pyplot.scatter`.
fill_between_kwargs: Key word arguments passed to
`matplotlib.pyplot.fill_between`, for plotting the confidence interval.
plot_kwargs: Key word arguments passed to `matplotlib.pyplot.plot` for
axline_kwargs: Key word arguments passed to `matplotlib.pyplot.axline` for
plotting the reference line. Pass {"disable": True} to avoid plotting.
ax: Matplotlib axes to use for the plot.

Expand Down Expand Up @@ -842,11 +842,11 @@ def qq(
if "c" not in scatter_kwargs and "color" not in scatter_kwargs:
scatter_kwargs["color"] = "black"

plot_kwargs = {} if plot_kwargs is None else plot_kwargs
axline_kwargs = {} if axline_kwargs is None else axline_kwargs

if "c" not in plot_kwargs and "color" not in plot_kwargs:
plot_kwargs["color"] = "gray"
plot_kwargs.setdefault("linestyle", "--")
if "c" not in axline_kwargs and "color" not in axline_kwargs:
axline_kwargs["color"] = "gray"
axline_kwargs.setdefault("linestyle", "--")
ax = plt.gca() if ax is None else ax
qq_data = qq_fun(gam)

Expand All @@ -859,10 +859,7 @@ def qq(
ax.scatter(qq_data.theoretical, qq_data.residuals, **scatter_kwargs)
ax.set_xlabel("Theoretical Quantiles")
ax.set_ylabel("Residuals")

min_val = min(ax.get_xlim()[0], ax.get_ylim()[0])
max_val = max(ax.get_xlim()[1], ax.get_ylim()[1])
_with_disable(ax.plot)([min_val, max_val], [min_val, max_val], **plot_kwargs)
_with_disable(ax.axline)((0, 0), slope=1, **axline_kwargs)
return ax


Expand Down
1 change: 0 additions & 1 deletion tests/test_plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ def test_qq(test_case: tc.GAMTestCase):
pass
else:
raise

plt.close("all")


Expand Down