feat(opencode): add lox-mcp code review agent in English#31
Merged
Conversation
Replace shaas-code-review with loxmcp-review. Inlined skill content and converted all instructions to English for public repo.
There was a problem hiding this comment.
Pull request overview
Adds an OpenCode agent definition (loxmcp-review.md) intended to guide consistent, English-only code reviews for the lox-mcp repository, covering local diffs, GitHub PR reviews, and follow-up reviews.
Changes:
- Introduces a new OpenCode review agent with a structured review workflow and output format.
- Defines review “modes” (local / GitHub PR / follow-up) and a checklist focused on security, performance, correctness, and best practices.
- Documents a regression-vs-intent gating approach to avoid false-positive “regression” blockers.
| @@ -0,0 +1,170 @@ | |||
| --- | |||
| description: >- | |||
| Performs thorough code review in English for lox-mcp repo. Three modes — local (branch vs main), | |||
Comment on lines
+14
to
+17
| tools: | ||
| write: false | ||
| edit: false | ||
| todowrite: false |
Comment on lines
+78
to
+82
| If diff contains changes to Kotlin files (`.kt` or `.kts`) or other files in `backend/`, run before completing review: | ||
|
|
||
| ```bash | ||
| cd backend && ./gradlew check | ||
| ``` |
Comment on lines
+86
to
+89
| After output, offer to save review locally: | ||
| > "Shall I save review to `.ai/local/`? (yes / no)" | ||
|
|
||
| If yes, suggest filename in format `.ai/local/review-<topic>-YYYY-MM-DD.md` and save using Write tool. |
| Always check: | ||
|
|
||
| - ✅ **Bugs** — logical errors, edge cases, null checks, race conditions; for shell/CLI commands check implicit default values (e.g., `psql` without `-d`, `aws s3` without `--region`) — every required context must be explicit; verify that new required resources (DB, schemas, users, directories) are created idempotently on every start — init scripts run only on first initialization (e.g., `docker-entrypoint-initdb.d`, cloud-init) do not run on existing deployments | ||
| - ✅ **Deploy risk** — if diff changes Dockerfile, docker-compose, entrypoint/init scripts or env vars, check new required env vars without defaults, impact of changes to shared base images (`backend/Dockerfile.gradle-base`, `backend/Dockerfile.python-base`), one-time init scripts without idempotent replacement, destructive migrations (drop/rename/type change/NOT NULL), changes to volume/mount paths and dependency on healthcheck (`depends_on: service_healthy`) |
| - ✅ **Performance** — unnecessary calculations, N+1 queries, memory leaks | ||
| - ✅ **Continuity** — style, patterns, consistency with codebase (see `.ai/rules/`) | ||
| - ✅ **Completeness** — are commits meaningful? Is change complete? | ||
| - ✅ **Commit quality** — messages clear? Correct type (feat/fix/refactor/perf)? Correct scope (be-/fe- prefix)? |
| - ✅ **Deploy risk** — if diff changes Dockerfile, docker-compose, entrypoint/init scripts or env vars, check new required env vars without defaults, impact of changes to shared base images (`backend/Dockerfile.gradle-base`, `backend/Dockerfile.python-base`), one-time init scripts without idempotent replacement, destructive migrations (drop/rename/type change/NOT NULL), changes to volume/mount paths and dependency on healthcheck (`depends_on: service_healthy`) | ||
| - ✅ **Security** — injection, validation, secrets, auth, permissions | ||
| - ✅ **Performance** — unnecessary calculations, N+1 queries, memory leaks | ||
| - ✅ **Continuity** — style, patterns, consistency with codebase (see `.ai/rules/`) |
| - **Be constructive** — framing as improvement, not criticism | ||
| - **Be specific** — each issue: WHAT (code/line), WHY (reason), HOW (solution) | ||
| - **Ask for context** — if intent or purpose is unclear | ||
| - **Respect standards** — see `.ai/rules/backend/kotlin.md`, `.ai/rules/backend/python.md`, `.ai/rules/frontend/react-typescript.md` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace shaas-code-review with lox-mcp code review agent. Inlined skill content directly in the agent file and converted all instructions to English for the public repository.
Key changes:
shaas-code-review.mdtoloxmcp-review.md