Skip to content

Make navigation sidebar sticky#45

Merged
heavyrubberslave merged 1 commit into
mainfrom
fix/sticky-navigation-sidebar
Jun 6, 2026
Merged

Make navigation sidebar sticky#45
heavyrubberslave merged 1 commit into
mainfrom
fix/sticky-navigation-sidebar

Conversation

@heavyrubberslave

@heavyrubberslave heavyrubberslave commented Jun 6, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • UI Improvements
    • Navigation drawer positioning has been updated for improved layout behavior.

@heavyrubberslave heavyrubberslave added the patch Creates a new patch/bugfix release if merged label Jun 6, 2026
@coderabbitai

coderabbitai Bot commented Jun 6, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Navigation drawer component props are simplified by removing absolute bottom positioning behavior. The drawer now uses temporary state binding with v-model="drawer" and temporary prop, altering how the menu drawer displays in the application layout.

Changes

Layout drawer positioning

Layer / File(s) Summary
Navigation drawer positioning props
src/layouts/LayoutWithMenu.vue
v-navigation-drawer props updated to remove absolute bottom positioning, retaining v-model="drawer" with temporary prop for drawer state management.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A drawer that danced at the bottom so low,
Now floats as it should, with a temporary glow,
Props simplified clean, positioning freed,
One change, one commit—exactly we need! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'Make navigation sidebar sticky' directly relates to the main change: removing absolute bottom positioning from the navigation drawer to change its positioning behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sticky-navigation-sidebar

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/layouts/LayoutWithMenu.vue`:
- Line 70: v-navigation-drawer is always set to temporary which forces overlay
behavior; change the static prop to a bound prop (e.g. :temporary="isTemporary")
and implement an isTemporary computed or data-driven boolean in
LayoutWithMenu.vue that returns true only on small screens. Use Vuetify's
breakpoint helper (this.$vuetify.breakpoint.smAndDown) or a window.matchMedia
listener inside the component (mounted + cleanup) to keep isTemporary in sync so
the drawer is temporary on mobile and docked/sticky on desktop; update any
places using `drawer` accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ea31189f-2265-48b7-b0f4-6f6c0585d6ad

📥 Commits

Reviewing files that changed from the base of the PR and between e109f77 and 111d0fa.

📒 Files selected for processing (1)
  • src/layouts/LayoutWithMenu.vue

Comment thread src/layouts/LayoutWithMenu.vue
@heavyrubberslave heavyrubberslave merged commit 52800b4 into main Jun 6, 2026
2 checks passed
@heavyrubberslave heavyrubberslave deleted the fix/sticky-navigation-sidebar branch June 6, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Creates a new patch/bugfix release if merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant