Make navigation sidebar sticky#45
Conversation
📝 WalkthroughWalkthroughNavigation drawer component props are simplified by removing ChangesLayout drawer positioning
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/layouts/LayoutWithMenu.vue`:
- Line 70: v-navigation-drawer is always set to temporary which forces overlay
behavior; change the static prop to a bound prop (e.g. :temporary="isTemporary")
and implement an isTemporary computed or data-driven boolean in
LayoutWithMenu.vue that returns true only on small screens. Use Vuetify's
breakpoint helper (this.$vuetify.breakpoint.smAndDown) or a window.matchMedia
listener inside the component (mounted + cleanup) to keep isTemporary in sync so
the drawer is temporary on mobile and docked/sticky on desktop; update any
places using `drawer` accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ea31189f-2265-48b7-b0f4-6f6c0585d6ad
📒 Files selected for processing (1)
src/layouts/LayoutWithMenu.vue
Summary by CodeRabbit