Repository navigation
Match intel system names that carry a '*' marker (#182) - #217
Merged
Merged
Conversation
Localised EVE clients can mark "important names" (systems, ships, items)
with a trailing '*', and the marker ends up in the chat log when such a
name is dragged into chat, e.g. "T-Q2DD*" or "BKG-Q2*".
The intel parser already tolerated a trailing '*' through its prefix
match, so the map overlay showed these systems. Double-clicking the intel
line, however, passed the raw word ("T-Q2DD*") to
RegionControl.SelectSystem, whose exact-name lookup failed, so the system
was never located. Strip '*' from each intel word before matching, and
select by the matched system's real name, which also fixes words typed
in a different case ("t-q2dd").
The parser now also matches a leading '*' typed for corrections
("*T-Q2DD") and abbreviations with a marker ("1DQ*").
Fixes Slazanger#182
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Localised EVE clients can mark "important names" (systems, ships, items) with a trailing
*, and the marker ends up in the chat log when such a name is dragged into chat, e.g. "T-Q2DD*" or "BKG-Q2*".The intel parser already tolerated a trailing
*through its prefix match, so the map overlay showed these systems. Double-clicking the intel line, however, passed the raw word ("T-Q2DD*") toRegionControl.SelectSystem, whose exact-name lookup failed, so the system was never located. Strip*from each intel word before matching, and select by the matched system's real name, which also fixes words typed in a different case ("t-q2dd").The parser now also matches a leading
*typed for corrections ("T-Q2DD") and abbreviations with a marker ("1DQ").Fixes #182