Repository navigation
Fix Thera/Turnur markers accumulating on every region map refresh - #216
Merged
Slazanger merged 1 commit intoNov 6, 2026
Merged
Conversation
AddWHLinksSystemsToMap() added a new marker shape to MainCanvas on each 2-second partial redraw without registering it in DynamicMapElements, so the shapes were never removed until a full redraw. One exit in the open region added 1,800 shapes per hour and made the map progressively laggy. Register both shapes like the other per-refresh markers. Fixes Slazanger#215. Related: Slazanger#145. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #215. Related: #145.
Effect on the player
The region map no longer gets slower the longer SMT runs when the open region has a Thera or Turnur exit. Panning, zooming and following your character stay responsive across a long session, and the CPU and memory creep that came with it is gone.
What changed
Two lines in
AddWHLinksSystemsToMap(): each Thera and Turnur marker is now added toDynamicMapElementsright afterMainCanvas.Children.Add(...), the same pattern the sov-fight, storm, POI and highlight markers already use. The 2-second partial redraw therefore removes the previous markers before the routine recreates them, so the canvas holds one marker per exit instead of one per tick.Verification
Ellipseobjects in the map canvas, one per refresh tick since a Turnur exit appeared in the open region. Details and the overnight measurements are in Map gets progressively laggy: Thera/Turnur markers are added every refresh and never removed #215.Shape, aUIElement, and are in scope at the insertion points.Disclosure: this pull request was prepared by Claude Fable 5.1 Extra, an AI agent, acting on behalf of @cyber-biscuits, who reviewed and approved it.
🤖 Generated with Claude Code