Skip to content

bindings/utils/dependencies.cpp : fix use of wrong define to tag URDF feature#34

Merged
jorisv merged 1 commit into
Simple-Robotics:pin4from
ManifoldFR:topic/python/fix-urdfdom-detect
Apr 8, 2026
Merged

bindings/utils/dependencies.cpp : fix use of wrong define to tag URDF feature#34
jorisv merged 1 commit into
Simple-Robotics:pin4from
ManifoldFR:topic/python/fix-urdfdom-detect

Conversation

@ManifoldFR

Copy link
Copy Markdown
Member

Description

pin.WITH_URDF always evaluated to False.

One consequence is that the unit tests bindings_geometry_model_urdf.py were always skipped.

Checklist

  • I have run pre-commit run --all-files or pixi run lint
  • I have performed a self-review of my own code
  • I have commented my code where necessary
  • I have made corresponding changes to the doxygen documentation
  • I have added tests that prove my fix or feature works
  • I have updated the CHANGELOG or added the "no changelog" label if it's a CI-related issue
  • I have updated the README credits section

@jorisv jorisv merged commit 0e5dd76 into Simple-Robotics:pin4 Apr 8, 2026
13 of 37 checks passed

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:

  • build_collision (build Pinocchio with coal support)
  • build_casadi (build Pinocchio with CasADi support)
  • build_autodiff (build Pinocchio with CppAD support)
  • build_codegen (build Pinocchio with CppADCodeGen support)
  • build_extra (build Pinocchio with extra algorithms)
  • build_mpfr (build Pinocchio with Boost.Multiprecision support)
  • build_sdf (build Pinocchio with SDF parser)
  • build_accelerate (build Pinocchio with APPLE Accelerate framework support)
  • build_all (build Pinocchio with ALL the options stated above)

Thanks.
The Pinocchio development team.

@ManifoldFR ManifoldFR deleted the topic/python/fix-urdfdom-detect branch April 8, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants